Skip to content

RFC net: dsa: add support for MT7988

Daniel Golle linux-arm-kernel linux-devicetree linux-mediatek lkml netdev 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 posting 2/214 patches 8 repliesApplied 14/14
  2. v3 RFC Latest15 patches 14 repliesIn review
  3. v2 RFC posting 1/22 patches 3 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v1 RFC2 patches6 repliesSuperseded

Changes in v3 from the cover letter

* split into many small commits to ease review
* introduce helper functions to reduce code duplication
* use helpers for locking to make lock-skipping easier and less ugly to implement.
* add dt-bindings for mediatek,mt7988-switch

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/15net: dsa: mt7530: refactor SGMII PCS creationdrivers/net/dsa/mt7530.c+50 -240 replies
2/15net: dsa: mt7530: use unlocked regmap accessorsdrivers/net/dsa/mt7530.c+14 -90 replies
3/15net: dsa: mt7530: use regmap to access switch register spacedrivers/net/dsa/mt7530.c drivers/net/dsa/mt7530.h+58 -323 replies
4/15net: dsa: mt7530: move SGMII PCS creation to mt7530_probe functiondrivers/net/dsa/mt7530.c+7 -60 replies
5/15net: dsa: mt7530: introduce mutex helpersdrivers/net/dsa/mt7530.c+36 -361 reply
6/15net: dsa: mt7530: move p5_intf_modes() function to mt7530.cdrivers/net/dsa/mt7530.c drivers/net/dsa/mt7530.h+18 -181 reply
7/15net: dsa: mt7530: introduce mt7530_probe_common helper functiondrivers/net/dsa/mt7530.c+47 -391 reply
8/15net: dsa: mt7530: introduce mt7530_remove_common helper functiondrivers/net/dsa/mt7530.c+12 -61 reply
9/15net: dsa: mt7530: split-off common parts from mt7531_setupdrivers/net/dsa/mt7530.c+55 -441 reply
10/15net: dsa: mt7530: introduce separate MDIO driverMAINTAINERS drivers/net/dsa/Kconfig drivers/net/dsa/Makefile +3 more+271 -2321 reply
11/15net: dsa: mt7530: skip locking if MDIO bus isn't presentdrivers/net/dsa/mt7530.c+4 -21 reply
12/15net: dsa: mt7530: add support for single-chip reset linedrivers/net/dsa/mt7530.c+6 -01 reply
13/15net: dsa: mt7530: add support for 10G link modes for CPU portdrivers/net/dsa/mt7530.c+6 -11 reply
14/15net: dsa: mt7530: introduce driver for MT7988 built-in switchMAINTAINERS drivers/net/dsa/Kconfig drivers/net/dsa/Makefile +3 more+201 -82 replies
15/15dt-bindings: net: dsa: mediatek,mt7530: add mediatek,mt7988-switchDocumentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml+24 -20 replies

Reviews trailers per patch

8 of 15 patches have a Reviewed-by or Acked-by.

PatchAndrew Lunn
1/15
2/15
3/15
4/15
5/15R-b
6/15R-b
7/15R-b
8/15R-b
9/15R-b
10/15R-b
11/15R-b
12/15
13/15R-b
14/15
15/15

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [RFC PATCH net-next v3 00/15] net: dsa: add support for MT7988

The MediaTek MT7988 SoC comes with a built-in switch very similar to previous MT7530 and MT7531. However, the switch address space is mapped into the SoCs memory space rather than being connected via MDIO. Using MMIO simplifies register access and also removes the need for a bus lock, and for that reason also makes interrupt handling more light-weight.

Note that this is different from previous SoCs like MT7621 and MT7623N which also came with an integrated MT7530-like switch which yet had to be accessed via MDIO.

Split-off the part of the driver registering an MDIO driver, then add another module acting as MMIO/platform driver.

Changes since v2:
* split into many small commits to ease review
* introduce helper functions to reduce code duplication
* use helpers for locking to make lock-skipping easier and less ugly to implement.
* add dt-bindings for mediatek,mt7988-switch

Changes since initial RFC:
* use regmap for register access and move register access to bus- specific driver
* move initialization of MT7531 SGMII PCS to MDIO driver

Daniel Golle (15):
net: dsa: mt7530: refactor SGMII PCS creation
net: dsa: mt7530: use unlocked regmap accessors
net: dsa: mt7530: use regmap to access switch register space
net: dsa: mt7530: move SGMII PCS creation to mt7530_probe function
net: dsa: mt7530: introduce mutex helpers
net: dsa: mt7530: move p5_intf_modes() function to mt7530.c
net: dsa: mt7530: introduce mt7530_probe_common helper function
net: dsa: mt7530: introduce mt7530_remove_common helper function
net: dsa: mt7530: split-off common parts from mt7531_setup
net: dsa: mt7530: introduce separate MDIO driver
net: dsa: mt7530: skip locking if MDIO bus isn't present
net: dsa: mt7530: add support for single-chip reset line
net: dsa: mt7530: add support for 10G link modes for CPU port
net: dsa: mt7530: introduce driver for MT7988 built-in switch
dt-bindings: net: dsa: mediatek,mt7530: add mediatek,mt7988-switch

 .../bindings/net/dsa/mediatek,mt7530.yaml     |  26 +-
 MAINTAINERS                                   |   3 +
 drivers/net/dsa/Kconfig                       |  28 +-
 drivers/net/dsa/Makefile                      |   4 +-
 drivers/net/dsa/mt7530-mdio.c                 | 242 ++++++++
 drivers/net/dsa/mt7530-mmio.c                 |  96 ++++
 drivers/net/dsa/mt7530.c                      | 519 +++++++++---------
 drivers/net/dsa/mt7530.h                      |  38 +-
 8 files changed, 653 insertions(+), 303 deletions(-)
 create mode 100644 drivers/net/dsa/mt7530-mdio.c
 create mode 100644 drivers/net/dsa/mt7530-mmio.c

base-commit: 86e2eca4ddedc07d639c44c990e1c220cac3741e

Signature · 1 line
2.39.2