Skip to content

RFC net: pcs: xpcs: cleanups for clause 73 support

Russell King (Oracle) netdev 2 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 RFC Latest0 of 9 patches 0 repliesNew
  2. v1 RFC0 of 9 patches 0 repliesSuperseded

Patches in v2 No applies recorded yet

None of the 9 patches the cover letter announces are in this archive.

Reviews trailers per patch

PatchAndrew Lunn
SeriesR-b R-b R-b R-b R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH RFC v2 net-next 0/9] net: pcs: xpcs: cleanups for clause 73 support

Hi,

This series cleans up xpcs code, moving much of the clause 73 code out of the driver into places where others can make use of it.

Specifically, we add a helper to convert a clause 73 advertisement to ethtool link modes to mdio.h, and a helper to resolve the clause 73 negotiation state to phylink, which includes the pause modes.

In doing this cleanup, several issues were identified with the original xpcs implementation:

1) it masks the link partner advertisement with its own advertisement so userspace can't see what the full link partner advertisement was.
2) it was always setting pause modes irrespective of the advertisements on either end of the link.
3) it was reading the STAT1 registers multiple times. Reading STAT1 has the side effect of unlatching the link-down status, so multiple reads should be avoided.

This patch series addresses the first two first by addressing the issues, and then by moving over to the new helpers. The third issue is solved by restructuring the xpcs code.

Obviously untested as I don't have xpcs hardware, so please can someone test these changes and give a tested-by for them? Thanks.

v2: add attributations, fix spelling mistake in patch 8, fix build error in patch 9.

 drivers/net/pcs/pcs-xpcs.c | 159 ++++++++++++++++++---------------------------
 drivers/net/pcs/pcs-xpcs.h |   3 -
 drivers/net/phy/phylink.c  |  54 +++++++++++----
 include/linux/mdio.h       |  39 +++++++++++
 include/linux/phylink.h    |   2 +
 include/uapi/linux/mdio.h  |  24 +++++++
 6 files changed, 170 insertions(+), 111 deletions(-)
Signature · 2 lines
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!