Skip to content

Cleanup Octeon DWC3 glue code

Ladislav Michl linux-mips linux-usb 5 versions – In review

Get series with b4
b4 am ZMd/HzISn0mPsNWt@lenoch

Versions newest first · linked by author and title

  1. v5 Latest7 patches 15 repliesIn review
  2. v46 patches 2 repliesSuperseded
  3. v33 patches 5 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v23 patches6 repliesSuperseded
v111 patches14 repliesSuperseded

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7usb: dwc3: dwc3-octeon: Convert to glue driverarch/mips/cavium-octeon/Makefile arch/mips/cavium-octeon/octeon-platform.c drivers/usb/dwc3/Kconfig +3 more+68 -510 replies
2/7usb: dwc3: dwc3-octeon: Use _ULL bitfields definesdrivers/usb/dwc3/dwc3-octeon.c+39 -392 replies
3/7usb: dwc3: dwc3-octeon: Pass dwc3_octeon to setup functionsdrivers/usb/dwc3/dwc3-octeon.c+12 -112 replies
4/7usb: dwc3: dwc3-octeon: Avoid half-initialized controller statedrivers/usb/dwc3/dwc3-octeon.c+43 -476 replies
5/7usb: dwc3: dwc3-octeon: Move node parsing into driver probedrivers/usb/dwc3/dwc3-octeon.c+60 -751 reply
6/7usb: dwc3: dwc3-octeon: Dump control register on clock init failuredrivers/usb/dwc3/dwc3-octeon.c+2 -21 reply
7/7usb: dwc3: dwc3-octeon: Add SPDX header and copyrightdrivers/usb/dwc3/dwc3-octeon.c+4 -63 replies

Reviews trailers per patch

All 7 patches have a Reviewed-by or Acked-by.

PatchThomas BogendoerferThinh NguyenPhilippe Mathieu-DaudéDavid Daney
1/7A-b A-b
2/7A-b R-b
3/7A-b R-b
4/7A-b
5/7A-b
6/7A-b R-b
7/7A-b R-b R-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v5 thread

Cover letter [PATCH v5 0/7] Cleanup Octeon DWC3 glue code

Hi!

The glue code currently lives in arch/mips/cavium-octeon/octeon-usb.c and loops for each "cavium,octeon-7130-usb-uctl" compatible. However there is no bond with dwc3 core code, so if anything goes wrong in glue code, the loop breaks, leaving dwc3 in reset.

Later on when dwc3 core tries to read any device register, bus error is emited, leading to kernel panic.

Therefore move it to drivers/usb/dwc3 while making it glue driver.

This is a fifth attempt splitted between more patches with warnings for 32bit test targets silenced, see changelog appended to them.

Ladislav Michl (7):
usb: dwc3: dwc3-octeon: Convert to glue driver
usb: dwc3: dwc3-octeon: Use _ULL bitfields defines
usb: dwc3: dwc3-octeon: Pass dwc3_octeon to setup functions
usb: dwc3: dwc3-octeon: Avoid half-initialized controller state
usb: dwc3: dwc3-octeon: Move node parsing into driver probe
usb: dwc3: dwc3-octeon: Dump control register on clock init failure
usb: dwc3: dwc3-octeon: Add SPDX header and copyright

 arch/mips/cavium-octeon/Makefile              |   1 -
 arch/mips/cavium-octeon/octeon-platform.c     |   1 -
 drivers/usb/dwc3/Kconfig                      |  10 +
 drivers/usb/dwc3/Makefile                     |   1 +
 .../usb/dwc3/dwc3-octeon.c                    | 429 +++++++++---------
 drivers/usb/dwc3/dwc3-of-simple.c             |   1 -
 6 files changed, 220 insertions(+), 223 deletions(-)
 rename arch/mips/cavium-octeon/octeon-usb.c => drivers/usb/dwc3/dwc3-octeon.c (61%)
Signature · 1 line
2.39.2

Read the cover letter in its thread