Skip to content

RFC Marvell PTP support

Russell King (Oracle) netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest0 of 5 patches 4 repliesIn review

Patches in v1 No applies recorded yet

None of the 5 patches the cover letter announces are in this archive.

Reviews trailers per patch

PatchKory Maincent
SeriesR-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH RFC net-next 0/5] Marvell PTP support

Hi,

This series is a work in progress, and represents the current state of things, superseding Kory's patches which were based in a very old version of my patches - and my patches were subsequently refactored and further developed about five years ago. Due to them breaking mvpp2 if merged, there was no point in posting them until such time that the underlying issues with PTP were resolved - and they now have been.

Marvell re-uses their PTP IP in several of their products - PHYs, switches and even some ethernet MACs contain the same IP. It really doesn't make sense to duplicate the code in each of these use cases.

Therefore, this series introduces a Marvell PTP core that can be re-used - a TAI module, which handles the global parts of the PTP core, and the TS module, which handles the per-port timestamping.

I will note at this point that although the Armada 388 TRM states that NETA contains the same IP, attempts to access the registers returns zero, and it is not known if that is due to the board missing something or whether it isn't actually implemented. I do have some early work re-using this, but when I discovered that the TAI registers read as zero and wouldn't accept writes, I haven't progressed that.

Today, I have converted the mv88e6xxx DSA code to use the Marvell TAI module from patch 1, and for the sake of getting the code out there, I have included the "hacky" patches in this series - with the issues with DSA VLANs that I reported this evening and subsequently investigated, I've not had any spare time to properly prepare that part of this series. (Being usurped from phylink by stmmac - for which I have a big stack of patches that I can't get out because of being usurped, and then again by Marvell PTP, and then again by DSA VLAN stuff... yea, I'm feeling like I have zero time to do anything right now.) The mv88e6xxx DSA code still needs to be converted to use the Marvell TS part of patch 1, but I won't be able to test that after Sunday, and I'm certainly not working on this over this weekend.

Anyway, this is what it is - and this is likely the state of it for a while yet, because I won't be able to sensibly access the hardware for testing for an undefined period of time.

The PHY parts seem to work, although not 100% reliably, with the occasional overrun, particularly on the receive side. I'm not sure whether this is down to a hardware bug or not, or MDIO driver bug, because we certainly aren't missing timestamping a SKB. This has been tested at L2 and L4.

I'm not sure which packets we should be timestamping (remembering that this is global config across all ports.)
https://chronos.uk/wordpress/wp-content/uploads/TechnicalBrief-IEEE1588v2PTP.pdf
suggests Sync, Delay_req and Delay_resp need to be timestamped, possibly PDelay_req and PDelay_resp as well, but I haven't seen those produced by PTPDv2 nor ptp4l.

There's probably other stuff I should mention, but as I've been at this into the evening for almost every day this week, I'm mentally exhausted.

Sorry also if this isn't coherent.

 drivers/net/dsa/mv88e6xxx/Kconfig               |   1 +
 drivers/net/dsa/mv88e6xxx/chip.h                |  26 +-
 drivers/net/dsa/mv88e6xxx/hwtstamp.c            |  17 +-
 drivers/net/dsa/mv88e6xxx/hwtstamp.h            |   1 +
 drivers/net/dsa/mv88e6xxx/ptp.c                 | 519 ++++++++-------------
 drivers/net/dsa/mv88e6xxx/ptp.h                 |   1 -
 drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c |   2 +
 drivers/net/phy/Kconfig                         |  13 +
 drivers/net/phy/Makefile                        |   1 +
 drivers/net/phy/marvell.c                       |  21 +-
 drivers/net/phy/marvell_ptp.c                   | 307 ++++++++++++
 drivers/net/phy/marvell_ptp.h                   |  21 +
 drivers/ptp/Kconfig                             |   4 +
 drivers/ptp/Makefile                            |   2 +
 drivers/ptp/ptp_marvell_tai.c                   | 449 ++++++++++++++++++
 drivers/ptp/ptp_marvell_ts.c                    | 593 ++++++++++++++++++++++++
 include/linux/marvell_ptp.h                     | 129 ++++++
 17 files changed, 1764 insertions(+), 343 deletions(-)
Signature · 2 lines
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!