Skip to content

net: phy: improve phylib EEE handling

Heiner Kallweit netdev 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest10 patches 6 repliesIn review
  2. v210 patches 1 replySuperseded
  3. v19 patches 10 repliesSuperseded

Changes in v3 from the cover letter

- patch4:
- remove trailing newline from NL_SET_ERR_MSG message

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/10net: phy: rename eee_broken_modes to eee_disabled_modesdrivers/net/phy/phy-c45.c drivers/net/phy/phy-core.c drivers/net/phy/phy_device.c +1 more+6 -60 replies
2/10net: phy: rename phy_set_eee_broken to phy_disable_eee_modedrivers/net/ethernet/realtek/r8169_main.c include/linux/phy.h+6 -60 replies
3/10ethtool: allow ethtool op set_eee to set an NL extack messageinclude/linux/ethtool.h net/ethtool/eee.c+2 -16 replies
4/10net: phy: c45: improve handling of disabled EEE modes in ethtool functionsdrivers/net/phy/phy-c45.c+8 -30 replies
5/10net: phy: move definition of phy_is_started before phy_disable_eee_modeinclude/linux/phy.h+7 -70 replies
6/10net: phy: improve phy_disable_eee_modeinclude/linux/phy.h+3 -00 replies
7/10net: phy: remove disabled EEE modes from advertising in phy_probedrivers/net/phy/phy_device.c+10 -110 replies
8/10net: phy: c45: Don't silently remove disabled EEE modes any longer when writing advertisement registerdrivers/net/phy/phy-c45.c+2 -50 replies
9/10net: phy: c45: use cached EEE advertisement in genphy_c45_ethtool_get_eeedrivers/net/phy/phy-c45.c+2 -20 replies
10/10net: phy: c45: remove local advertisement parameter from genphy_c45_eee_is_activedrivers/net/phy/phy-c45.c drivers/net/phy/phy.c include/linux/phy.h+12 -260 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [PATCH net-next v3 00/10] net: phy: improve phylib EEE handling

This series includes improvements for the EEE handling in phylib.

v2:
- add patch 3
- patch 4:
- silently filter out disabled EEE modes
- add extack user hint if requested EEE advertisement includes disabled modes

v3:
- patch4:
- remove trailing newline from NL_SET_ERR_MSG message

Heiner Kallweit (10):
net: phy: rename eee_broken_modes to eee_disabled_modes
net: phy: rename phy_set_eee_broken to phy_disable_eee_mode
ethtool: allow ethtool op set_eee to set an NL extack message
net: phy: c45: improve handling of disabled EEE modes in ethtool
functions
net: phy: move definition of phy_is_started before
phy_disable_eee_mode
net: phy: improve phy_disable_eee_mode
net: phy: remove disabled EEE modes from advertising in phy_probe
net: phy: c45: Don't silently remove disabled EEE modes any longer
when writing advertisement register
net: phy: c45: use cached EEE advertisement in
genphy_c45_ethtool_get_eee
net: phy: c45: remove local advertisement parameter from
genphy_c45_eee_is_active

 drivers/net/ethernet/realtek/r8169_main.c |  6 +--
 drivers/net/phy/phy-c45.c                 | 51 +++++++++--------------
 drivers/net/phy/phy-core.c                |  2 +-
 drivers/net/phy/phy.c                     |  4 +-
 drivers/net/phy/phy_device.c              | 23 +++++-----
 include/linux/ethtool.h                   |  1 +
 include/linux/phy.h                       | 24 ++++++-----
 net/ethtool/eee.c                         |  2 +-
 8 files changed, 52 insertions(+), 61 deletions(-)
Signature · 1 line
2.47.1