Remove defines for SPI default speed and mode
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest5 of 7 patches 0 repliesNew
5 of 7 patches are in this archive. The cover letter announces 7.
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/7 | spi: update management of default speed and mode | +0 | 1 reply | |
| 1/7 | spi: update management of default speed and mode | +0 | 0 replies | |
| 2/7 | spi: add comment for spi_flash_probe_bus_cs function | +0 | 1 reply | |
| 6/7 | env: Read default speed and mode values from DT | +0 | 0 replies | |
| 7/7 | spi: remove define for SPI default SPEED and MODE | +0 | 1 reply |
Reviews trailers per patch
All 5 patches have a Reviewed-by or Acked-by.
| Patch | Simon Goldschmidt | Petr Vorel |
|---|---|---|
| Series | T-b | |
| 1/7 | R-b | R-b |
| 1/7 | R-b | R-b |
| 2/7 | R-b | R-b |
| 6/7 | R-b | |
| 7/7 | R-b | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [U-Boot] [PATCH 0/7] Remove defines for SPI default speed and mode
Am 10.12.2018 um 16:42 schrieb Adam Ford:
Quoted 13 lines
Quoted 11 lines · Patrick Delaunay
This patch-set finish (after the last Simmon comment) and depends on the previous serie named:
"Read default speed and mode values from DT"http://patchwork.ozlabs.org/project/uboot/list/?series=76834
This patchset remove the unnecessary defines for SPI speed and mode when DM mode is used for SPI (
CONFIG_DM_SPI_FLASH).
Quoted 7 lines
Quoted 5 lines
Build result is available for the serie in gihub and travis:
https://github.com/patrickdelaunay/u-boot/tree/topic/spi
https://travis-ci.org/patrickdelaunay/u-boot/branchesAfter applying both of your patches, the da850evm no longer boots from SPI flash.
I just did test this and it worked for me. Booting from QSPI on socfpga_socrates and loading something in U-Boot via sf probe/sf read, so:
Quoted 11 lines
U-Boot SPL 2019.01-rc1-00754-g21fb8c41b1 (Dec 10 2018 - 09:02:28 -0600) Trying to boot from SPI
Warning: SPI speed fallback to 100 kHz[repeat in perpetuity]
U-Boot SPL 2019.01-rc1-00754-g21fb8c41b1 (Dec 10 2018 - 09:02:28 -0600) Trying to boot from SPI
Warning: SPI speed fallback to 100 kHz
Quoted 8 lines
I then tried to apply the first patch, and it also fails booting.
I'll reply to the original series with a similar message. Looking at the comments, it looks like the code is assuming the
DM_SPI_FLASHmeans DT when in reality, the da850evm's SPL is using platdata. I looked at the platdata structure and I didn't see entries for SPI mode or speed. However, I cannot prove this is the issue on the da850evm without diving into it a bit more.
Adam, from reading the da850-emv.dts and its '-u-boot.dtsi', it seems the fdtgrep indicators to keep the flash for the SPL dts are missing (compare to socfpga_cyclone5_socrates-u-boot.dtsi). In this case, the code does not find a flash node.
The same would of course apply when using platdata.
Regards,
Simon
Quoted 27 lines
adam
Quoted 25 lines
Patrick Delaunay (7):
spi: update management of default speed and mode
spi: add comment forspi_flash_probe_bus_csfunction
da850evm: sf: Read default speed and mode values from DT
dfu: sf: Read default speed and mode values from DT
mips: mt76xx: gardena-smart-gateway: Read default speed and mode
values from DT
env: Read default speed and mode values from DT
spi: remove define for SPI default SPEED and MODEboard/davinci/da8xxevm/da850evm.c | 7 +++++++ board/gardena/smart-gateway-mt7688/board.c | 24 ++++++++++++++++++++---- cmd/sf.c | 10 ++++++---- common/spl/spl_spi.c | 11 ++++++----- common/splash_source.c | 11 ++++++----- drivers/dfu/dfu_sf.c | 10 ++++++++-- env/Kconfig | 4 ++-- env/sf.c | 5 ++++- include/spi_flash.h | 18 ++++++++++++++++++ 9 files changed, 77 insertions(+), 23 deletions(-)--
2.7.4