Skip to content

PCI: Disable parity checking if broken_parity is set

Heiner Kallweit linux-arm-kernel linux-pci netdev 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest3 patches 5 repliesIn review
  2. v23 patches 2 repliesSuperseded
  3. v13 patches 6 repliesSuperseded

v2 from the cover letter

- reduce scope of N2100 change to using the new PCI core quirk v3:
- improve commit message of patch 2

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3PCI: Disable parity checking if broken_parity is setdrivers/pci/quirks.c include/linux/pci.h+13 -65 replies
2/3ARM: iop32x: improve N2100 PCI broken parity quirkarch/arm/mach-iop32x/n2100.c+1 -10 replies
3/3r8169: simplify broken parity handling now that PCI core takes caredrivers/net/ethernet/realtek/r8169_main.c+0 -140 replies

Reviews trailers per patch

1 of 3 patches has a Reviewed-by or Acked-by.

PatchLeon RomanovskyBjorn Helgaas
1/3R-b A-b
2/3
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/3] PCI: Disable parity checking if broken_parity is set

If we know that a device has broken parity checking, then disable it. This avoids quirks like in r8169 where on the first parity error interrupt parity checking will be disabled if broken_parity_status is set. Make pci_quirk_broken_parity() public so that it can be used by platform code, e.g. for Thecus N2100.

v2:
- reduce scope of N2100 change to using the new PCI core quirk v3:
- improve commit message of patch 2

Heiner Kallweit (3):
PCI: Disable parity checking if broken_parity_status is set
ARM: iop32x: improve N2100 PCI broken parity quirk
r8169: simplify broken parity handling now that PCI core takes care

 arch/arm/mach-iop32x/n2100.c              |  2 +-
 drivers/net/ethernet/realtek/r8169_main.c | 14 --------------
 drivers/pci/quirks.c                      | 17 +++++++++++------
 include/linux/pci.h                       |  2 ++
 4 files changed, 14 insertions(+), 21 deletions(-)
Signature · 1 line
2.30.0