net: rework SFP capability parsing and quirks
Status from this message: This series was applied to netdev/net-next.git (main)
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest0 of 7 patches 1 replyApplied
- v10 of 7 patches 0 repliesSuperseded
Changes in v2 from the cover letter
- Add Andrew's r-b to patch 1
- sfp_module_may_have_phy() -> sfp_module_parse_may_have_phy()
Patches in v2 Applied
None of the 7 patches the cover letter announces are in this archive.
Reviews trailers per patch
| Patch | Andrew Lunn |
|---|---|
| Series | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH net-next v2 0/7] net: rework SFP capability parsing and quirks
The original SPF module parsing was implemented prior to gaining any quirks, and was designed such that the upstream calls the parsing functions to get the translated capabilities of the module.
SFP quirks were then added to cope with modules that didn't correctly fill out their ID EEPROM. The quirk function was called from sfp_parse_support() to allow quirks to modify the ethtool link mode masks.
Using just ethtool link mode masks eventually lead to difficulties determining the correct phy_interface_t mode, so a bitmap of these modes were added - needing both the upstream API and quirks to be updated.
We have had significantly more SFP module quirks added since, some which are modifying the ID EEPROM as a way of influencing the data we provide to the upstream - for example, sfp_fixup_10gbaset_30m() changes id.base.connector so we report PORT_TP. This could be done more cleanly if the quirks had access to the parsed SFP port.
In order to improve flexibility, and to simplify some of the upstream code, we group all module capabilities into a single structure that the upstream can access via sfp_module_get_caps(). This will allow the module capabilities to be expanded if required without reworking all the infrastructure and upstreams again.
In this series, we rework the SFP code to use the capability structure and then rework all the upstream implementations, finally removing the old kernel internal APIs.
---
v2:
- Add Andrew's r-b to patch 1
- sfp_module_may_have_phy() -> sfp_module_parse_may_have_phy()
drivers/net/phy/marvell-88x2222.c | 13 +++-- drivers/net/phy/marvell.c | 8 ++- drivers/net/phy/marvell10g.c | 7 ++- drivers/net/phy/phylink.c | 11 ++-- drivers/net/phy/qcom/at803x.c | 9 ++-- drivers/net/phy/qcom/qca807x.c | 7 ++- drivers/net/phy/sfp-bus.c | 107 ++++++++++++++++---------------------- drivers/net/phy/sfp.c | 49 +++++++++-------- drivers/net/phy/sfp.h | 4 +- include/linux/phy.h | 5 ++ include/linux/sfp.h | 48 +++++++++-------- 11 files changed, 126 insertions(+), 142 deletions(-)
Signature · 2 lines
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!