Skip to content

don't abuse task_struct.group_leader

Oleg Nesterov amd-gfx dri-devel linux-rdma lkml netdev 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest7 patches 3 repliesIn review 6 of 7 applied
  2. v17 patches 9 repliesSuperseded

Patches in v2 6 of 7 applied

#Subject and filesSizeRepliesApplied
1/7android/binder: don't abuse current->group_leaderdrivers/android/binder.c drivers/android/binder_alloc.c+4 -50 replies
2/7android/binder: use same_thread_group(proc->tsk, current) in binder_mmap()drivers/android/binder.c+1 -10 repliesApplied
3/7drm/amdgpu: don't abuse current->group_leaderdrivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c+2 -20 repliesApplied
4/7drm/amd: kill the outdated "Only the pthreads threading model is supported" checksdrivers/gpu/drm/amd/amdgpu/amdgpu_vm.c drivers/gpu/drm/amd/amdkfd/kfd_process.c+0 -130 repliesApplied
5/7drm/pan*: don't abuse current->group_leaderdrivers/gpu/drm/panfrost/panfrost_gem.c drivers/gpu/drm/panthor/panthor_gem.c+2 -20 repliesApplied
6/7RDMA/umem: don't abuse current->group_leaderdrivers/infiniband/core/umem_odp.c+2 -20 repliesApplied
7/7netclassid: use thread_group_leader(p) in update_classid_task()net/core/netclassid_cgroup.c+1 -13 repliesApplied

Reviews trailers per patch

All 7 patches have a Reviewed-by or Acked-by.

PatchAlice RyhlFelix KuehlingChristian KönigBoris BrezillonSteven PriceLeon RomanovskyJakub Kicinski
1/7R-b
2/7R-b
3/7A-b
4/7A-b R-b
5/7A-b A-b
6/7A-b
7/7A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 7 reviewers.

Read the v2 thread

Cover letter [PATCH v2 0/7] don't abuse task_struct.group_leader

Andrew, can you take these simple cleanups?

The patches do not depend on each other, this series just removes the usage of ->group_leader when it is "obviously unnecessary".

I am going to move ->group_leader from task_struct to signal_struct or at least add the new task_group_leader() helper. So I will send more tree-wide changes on top of this series.

Link to V1: https://lore.kernel.org/all/[email protected]/

V2 doesn't differ, I only added the acks I got (thanks!).

7/7 was not reviewed, but looks really trivial.

Oleg.
---

 drivers/android/binder.c                         |  9 ++++-----
 drivers/android/binder_alloc.c                   |  2 +-
 drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c |  2 +-
 drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c           |  5 +----
 drivers/gpu/drm/amd/amdkfd/kfd_process.c         | 10 ----------
 drivers/gpu/drm/panfrost/panfrost_gem.c          |  2 +-
 drivers/gpu/drm/panthor/panthor_gem.c            |  2 +-
 drivers/infiniband/core/umem_odp.c               |  4 ++--
 net/core/netclassid_cgroup.c                     |  2 +-
 9 files changed, 12 insertions(+), 26 deletions(-)