Skip to content

platform/x86: int3472: Add support for GPIO type 0x02 (IR flood LED)

Marco Nenciarini lkml platform-driver-x86 7 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v8 Latest4 patches 4 repliesIn review
  2. v74 patches 6 repliesSuperseded
  3. v64 patches 9 repliesSuperseded
Earlier versions · 4
VersionPostedPatchesRepliesStatus
v54 patches14 repliesSuperseded
v44 patches6 repliesSuperseded
v32 patches5 repliesSuperseded
v11 patch0 repliesSuperseded

Changes in v8 from the cover letter

- Always register the LED lookup for ir_flood too, removing the type parameter and conditional switch-case from patch 4 (Hans de Goede, Andy Shevchenko)

Patches in v8 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4platform/x86: int3472: Use local variable for LED struct accessdrivers/platform/x86/intel/int3472/led.c+22 -210 replies
2/4platform/x86: int3472: Rename pled to led in LED registration codedrivers/platform/x86/intel/int3472/discrete.c drivers/platform/x86/intel/int3472/led.c include/linux/platform_data/x86/int3472.h+13 -130 replies
3/4platform/x86: int3472: Parameterize LED con_id in registrationdrivers/platform/x86/intel/int3472/discrete.c drivers/platform/x86/intel/int3472/led.c include/linux/platform_data/x86/int3472.h+8 -61 reply
4/4platform/x86: int3472: Add support for GPIO type 0x02 (IR flood LED)drivers/platform/x86/intel/int3472/discrete.c drivers/platform/x86/intel/int3472/led.c include/linux/platform_data/x86/int3472.h+25 -142 replies

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchAndy ShevchenkoHans de Goede
1/4R-b R-b
2/4R-b R-b
3/4R-b R-b
4/4R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v8 thread

Cover letter [PATCH v8 0/4] platform/x86: int3472: Add support for GPIO type 0x02 (IR flood LED)

Add support for INT3472 GPIO type 0x02 which controls an IR flood LED used for face authentication on some laptops (e.g. Dell Pro Max 16 Premium). Without this, the kernel logs "GPIO type 0x02 unknown; the sensor may not work" and IR sensors paired with a flood LED cannot function.

The series first refactors the existing LED code (patches 1-3), then adds the new IR flood LED type with multi-LED support (patch 4).

Changes in v8:
- Always register the LED lookup for ir_flood too, removing the type parameter and conditional switch-case from patch 4 (Hans de Goede, Andy Shevchenko)

Marco Nenciarini (4):
platform/x86: int3472: Use local variable for LED struct access platform/x86: int3472: Rename pled to led in LED registration code platform/x86: int3472: Parameterize LED con_id in registration platform/x86: int3472: Add support for GPIO type 0x02 (IR flood LED)

 drivers/platform/x86/intel/int3472/discrete.c | 13 ++++-
 drivers/platform/x86/intel/int3472/led.c      | 55 ++++++++++---------
 include/linux/platform_data/x86/int3472.h     | 12 ++--
 3 files changed, 47 insertions(+), 33 deletions(-)
Signature · 1 line
2.47.3