Skip to content

pipe: only enable the extra wake_up(rd_wait) when epoll is actually used

Oleg Nesterov io-uring linux-fsdevel lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest1 patch 10 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/1pipe: only enable the extra wake_up(rd_wait) when epoll is actually usedfs/pipe.c include/linux/pipe_fs_i.h+23 -61 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/1] pipe: only enable the extra wake_up(rd_wait) when epoll is actually used

Breno, Christian, Mateusz,

To be honest, I am not sure this change makes a lot of sense. But somehow the extra wakeup in anon_pipe_write() looks annoying to me.

Can you take a look?

Plus I'd like to know what sashiko.dev thinks.

I have no idea how to test it wrt performance...

Oleg.
---

 fs/pipe.c                 | 23 +++++++++++++++++++----
 include/linux/pipe_fs_i.h |  6 ++++--
 2 files changed, 23 insertions(+), 6 deletions(-)