net/rds: move sysctl-only code under CONFIG_SYSCTL
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest5 patches 2 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/5 | net/rds/sysctl.c: move sysctl-only code under CONFIG_SYSCTLnet/ | +20 | 0 replies | |
| 2/5 | net/rds/ib_sysctl.c: move sysctl-only code under CONFIG_SYSCTLnet/ | +23 | 0 replies | |
| 3/5 | net/rds/tcp.c: introduce rds_tcp_{init,exit}_net_sysctl() helpersnet/ | +52 | 0 replies | |
| 4/5 | net/rds/tcp.c: move sysctl-only code under CONFIG_SYSCTLnet/ net/ | +74 | 0 replies | |
| 5/5 | net/rds: remove dead sysctl declarationsnet/ net/ | +0 | 0 replies |
Reviews trailers per patch
None of the 5 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Allison Henderson |
|---|---|
| Series | R-b T-b |
| 1/5 | |
| 2/5 | |
| 3/5 | |
| 4/5 | |
| 5/5 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 0/5] net/rds: move sysctl-only code under CONFIG_SYSCTL
On top of
[PATCH net 0/2] net/rds: fix init failures leaving built-in transports on a dead core https://lore.kernel.org/all/[email protected]/
Allison, Joel, I am sending this mostly to "complete" the previous discussions. I won't argue if you think these cleanups do not make a lot of sense.
And of course, I can't test them. I just verified that the kernel with CONFIG_RDS CONFIG_RDS_RDMA CONFIG_RDS_TCP CONFIG_RDS_DEBUG builds with or without CONFIG_SYSCTL.
However, I decided to abuse sashiko.dev and sent the cumulative "not for inclusion" patch, sashiko didn't find any problem:
[PATCH] net/rds: move the sysctl code under ifdef(SYSCTL)
https://sashiko.dev/#/patchset/atyHdPlxALv0Nnyj%40redhat.com
Oleg.
net/rds/ib.h | 1 - net/rds/ib_sysctl.c | 33 +++++--- net/rds/rds.h | 5 -- net/rds/sysctl.c | 26 ++++-- net/rds/tcp.c | 230 ++++++++++++++++++++++++++++------------------------ net/rds/tcp.h | 2 + 6 files changed, 168 insertions(+), 129 deletions(-)