Skip to content

mark t3701-add-interactive.sh as leak-free

Rubén Justo git 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest4 patches 1 replyIn review
  2. v14 patches 8 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4apply: plug a leak in apply_dataapply.c t/t2016-checkout-patch.sh t/t4103-apply-binary.sh +6 more+12 -10 replies
2/4add-interactive: plug a leak in get_untracked_filesadd-interactive.c+1 -00 replies
3/4add-patch: plug a leak handling the '/' commandadd-patch.c+1 -00 replies
4/4add: plug a leak on interactive_addbuiltin/add.c t/t3701-add-interactive.sh t/t7514-commit-patch.sh+9 -30 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 0/4] mark t3701-add-interactive.sh as leak-free

Rubén Justo (4):
apply: plug a leak in apply_data
add-interactive: plug a leak in get_untracked_files
add-patch: plug a leak handling the '/' command
add: plug a leak on interactive_add

 add-interactive.c          | 1 +
 add-patch.c                | 1 +
 apply.c                    | 4 +++-
 builtin/add.c              | 9 ++++++---
 t/t2016-checkout-patch.sh  | 1 +
 t/t3701-add-interactive.sh | 1 +
 t/t4103-apply-binary.sh    | 1 +
 t/t4104-apply-boundary.sh  | 1 +
 t/t4113-apply-ending.sh    | 1 +
 t/t4117-apply-reject.sh    | 1 +
 t/t4123-apply-shrink.sh    | 1 +
 t/t4252-am-options.sh      | 2 ++
 t/t4258-am-quoted-cr.sh    | 1 +
 t/t7514-commit-patch.sh    | 2 ++
 14 files changed, 23 insertions(+), 4 deletions(-)

Range-diff against v1:
1: 18e4c7f653 ! 1: 75cb700eab apply: plug a leak in apply_data
@@ Metadata
## Commit message ##
apply: plug a leak in apply_data

- Plug a leak we have since cfb6f9acc3 (apply: accept -3/--3way command
- line option, 2012-05-08).
+ We have an execution path in apply_data that leaks the local struct
+ image. Plug it.

This leak can be triggered with:

2:  21d6c2dd16 = 2:  bee002b0ae add-interactive: plug a leak in get_untracked_files
3:  f69a6a30a1 = 3:  7d1a94dd91 add-patch: plug a leak handling the '/' command
4:  5d9607f153 = 4:  fff7e48949 add: plug a leak on interactive_add
Signature · 1 line
2.45.0.rc0.4.gfff7e48949