Skip to content

i2c: gpio: support write-only sda

Heiner Kallweit linux-devicetree linux-i2c 5 versions – Applied

Status from this message: Applied to for-next, thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest3 patches 5 repliesApplied
  2. v43 patches 2 repliesSuperseded
  3. v33 patches 5 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v23 patches5 repliesSuperseded
v13 patches1 replySuperseded

Changes in v5 from the cover letter

- patch 1: add checking mutually-exclusive attributes to schema

Patches in v5 Applied

#Subject and filesSizeRepliesApplied
1/3dt-bindings: i2c-gpio: Add properties for dealing with write-only SDA/SCL w/o pullupDocumentation/devicetree/bindings/i2c/i2c-gpio.yaml+26 -02 replies
2/3i2c: algo: bit: allow getsda to be NULLdrivers/i2c/algos/i2c-algo-bit.c+35 -421 reply
3/3i2c: gpio: support write-only sda/scl w/o pull-updrivers/i2c/busses/i2c-gpio.c include/linux/platform_data/i2c-gpio.h+19 -31 reply

Reviews trailers per patch

1 of 3 patches has a Reviewed-by or Acked-by.

PatchRob Herring
1/3R-b
2/3
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v5 thread

Cover letter [PATCH v5 0/3] i2c: gpio: support write-only sda

There are slave devices that understand I2C but have read-only SDA and SCL. Examples are FD650 7-segment LED controller and its derivatives. Typical board designs don't even have a pull-up for both pins. Therefore add properties for not using open-drain. For write-only SCL we have a property already, add one for write-only SDA.

v2:
- improve commit message for patch 1

v3:
- patch 2: check for adap->getsda in readbytes()
- patch 2: align warning message level for info on missing getscl/getsda
- patch 3: improve description of attribute sda_is_output_only

v4:
- patch 1: add no-pullup properties
- patch 2: handle SDA and SCL independently
- patch 2: properly handle case that SDA is NULL but SCL not
- patch 3: handle new no-pullup attributes
v5:
- patch 1: add checking mutually-exclusive attributes to schema

Heiner Kallweit (3):
dt-bindings: i2c-gpio: Add properties for dealing with write-only SDA/SCL w/o pullup
i2c: algo: bit: allow getsda to be NULL
i2c: gpio: support write-only sda/scl w/o pull-up

 .../devicetree/bindings/i2c/i2c-gpio.yaml     | 26 +++++++
 drivers/i2c/algos/i2c-algo-bit.c              | 77 +++++++++----------
 drivers/i2c/busses/i2c-gpio.c                 | 13 +++-
 include/linux/platform_data/i2c-gpio.h        |  9 +++
 4 files changed, 80 insertions(+), 45 deletions(-)
Signature · 1 line
2.39.0