Skip to content

r8169: remove fiddling with the PCIe max read request size

Heiner Kallweit netdev 1 version Applied

Status from this message: Applied, thanks!

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 1 replyApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/4r8169: remove fiddling with the PCIe max read request sizedrivers/net/ethernet/realtek/r8169_main.c+4 -360 replies
2/4r8169: simplify setting PCI_EXP_DEVCTL_NOSNOOP_ENdrivers/net/ethernet/realtek/r8169_main.c+10 -240 replies
3/4r8169: remove rtl_hw_start_8168dpdrivers/net/ethernet/realtek/r8169_main.c+1 -80 replies
4/4r8169: remove rtl_hw_start_8168befdrivers/net/ethernet/realtek/r8169_main.c+4 -110 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH net-next 0/4] r8169: remove fiddling with the PCIe max read request size

The attempt to improve performance by changing the PCIe max read request size was added in the vendor driver more than 10 years back and copied to r8169 driver. In the vendor driver this has been removed long ago. Obviously it had no effect, also in my tests I didn't see any difference. Typically the max payload size is less than 512 bytes anyway, and the PCI core takes care that the maximum supported value is set. So let's remove fiddling with PCIe max read request size from r8169 too. This change allows to simplify the driver in the subsequent three patches of this series.

Heiner Kallweit (4):
r8169: remove fiddling with the PCIe max read request size
r8169: simplify setting PCI_EXP_DEVCTL_NOSNOOP_EN
r8169: remove rtl_hw_start_8168dp
r8169: remove rtl_hw_start_8168bef

 drivers/net/ethernet/realtek/r8169_main.c | 90 ++++-------------------
 1 file changed, 15 insertions(+), 75 deletions(-)
Signature · 1 line
2.23.0