Split-up "unpack_trees()" cleanup series
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest5 patches 6 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/5 | Add 'df_name_compare()' helper functioncache.h read-cache.c | +36 | 3 replies | |
| 2/5 | Make 'traverse_tree()' use linked structure rather than 'const char *base'merge-tree.c tree-walk.c tree-walk.h | +78 | 0 replies | |
| 3/5 | Add return value to 'traverse_tree()' callbackmerge-tree.c tree-walk.c tree-walk.h | +22 | 0 replies | |
| 4/5 | Make 'traverse_trees()' traverse conflicting DF entries in parallelmerge-tree.c tree-walk.c tree-walk.h | +9 | 0 replies | |
| 5/5 | Move 'unpack_trees()' over to 'traverse_trees()' interfaceunpack-trees.c | +249 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 0/5] Split-up "unpack_trees()" cleanup series
Ok, here's the patch I sent out earlier, except now it's been split up into a series fo five patches (and has some trivial one-liner cleanups here and there, mainly to shrink the patches a bit)
It's a series of five patches:
- Add 'df_name_compare()' helper function
- Make 'traverse_tree()' use linked structure rather than 'const char *base'
- Add return value to 'traverse_tree()' callback
- Make 'traverse_trees()' traverse conflicting DF entries in parallel
- Move 'unpack_trees()' over to 'traverse_trees()' interface
with a more lines added than removed:
cache.h | 1 + merge-tree.c | 58 ++++--- read-cache.c | 35 ++++ tree-walk.c | 59 ++++++- tree-walk.h | 23 ++- unpack-trees.c | 530 ++++++++++++++++++++++++++------------------------------ 6 files changed, 387 insertions(+), 319 deletions(-)
but especially in this new split-up format, it's now more possible to see how the last patch actually simplifies things.