Fix git's test suite to pass when the path contains spaces
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 Latest10 patches 7 repliesIn review
- v210 patches 3 repliesSuperseded
- v18 patches 19 repliesSuperseded
Patches in v3 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/10 | git-rebase.sh: Fix --merge --abort failures when path contains whitespacegit-rebase.sh t/ | +22 | 0 replies | |
| 2/10 | config.c: Escape backslashes in section names properlyconfig.c t/ | +7 | 0 replies | |
| 3/10 | git-send-email.perl: Handle shell metacharacters in $EDITOR properlygit-send-email.perl t/ | +7 | 0 replies | |
| 4/10 | test-lib.sh: Add a test_set_editor function to safely set $VISUALt/ | +16 | 0 replies | |
| 5/10 | Use test_set_editor in t9001-send-email.sht/ | +1 | 0 replies | |
| 6/10 | test-lib.sh: Fix some missing path quotingt/ | +1 | 0 replies | |
| 7/10 | lib-git-svn.sh: Fix quoting issues with paths containing shell metacharacterst/ | +2 | 0 replies | |
| 8/10 | Don't use the export NAME=value form in the test scripts.t/ t/ t/ +7 more | +52 | 0 replies | |
| 9/10 | Fix tests breaking when checkout path contains shell metacharacterst/ t/ t/ +33 more | +460 | 3 replies | |
| 10/10 | Rename the test trash directory to contain spaces.t/ t/ t/ +1 more | +12 | 1 reply |
Reviews trailers per patch
None of the 10 patches has a Reviewed-by or Acked-by.
| Patch | Johannes Sixt |
|---|---|
| Series | T-b |
| 1/10 | |
| 2/10 | |
| 3/10 | |
| 4/10 | |
| 5/10 | |
| 6/10 | |
| 7/10 | |
| 8/10 | |
| 9/10 | |
| 10/10 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v3 00/10] Fix git's test suite to pass when the path contains spaces
This patch series fixes bugs in git and git's testsuite to allow all tests to pass when the working directory contains whitespace and/or shell metacharacters.
The first three patches in this series fix bugs in git itself that were uncovered in the process of fixing the test suite. Each contains additional tests and/or updates to existing tests to exercise the bug in question.
Patches 4 and 5 set up an abstraction for safe handling of editor variables in tests when we have odd paths; and 6-7 fix bugs in the test libraries. Patch 8 cleans up some instances of the unportable export FOO=bar construct in the test suite; patch 9 fixes the remaining individual tests to be space-sane, and finally 10 arranges for the test suite to always run with the trash directory name containing spaces, to help prevent regressions in the future.
Significant changes since v2:
* Use only spaces in the trash dir names for Windows compatibility
* Avoid ugliness like \"\$GIT_DIR\"
This series is also available by:
git pull git://repo.or.cz/git/bdonlan.git wst-submit3
Sorry for the long delay in updating the series; I've been consumed with schoolwork lately :)
Since it was mentioned providing conversion scripts was useful in review, here is a hacky script I put together to help fixup the quotation:
http://fushizen.net/~bd/requote.pl
This script was applied on t/t*svn*.sh, then followed by a few manual fixes, review, and git add -i to change only the chunks that I had made worse in the previous patches. Note however that the conversion of "->' in places makes for a large diff...
Bryan Donlan (10):
git-rebase.sh: Fix --merge --abort failures when path contains
whitespace
config.c: Escape backslashes in section names properly git-send-email.perl: Handle shell metacharacters in $EDITOR properly test-lib.sh: Add a test_set_editor function to safely set $VISUAL Use test_set_editor in t9001-send-email.sh
test-lib.sh: Fix some missing path quoting lib-git-svn.sh: Fix quoting issues with paths containing shell
metacharacters
Don't use the export NAME=value form in the test scripts. Fix tests breaking when checkout path contains shell metacharacters Rename the test trash directory to contain spaces.
config.c | 2 +- git-rebase.sh | 2 +- git-send-email.perl | 2 +- t/.gitignore | 2 +- t/lib-git-svn.sh | 3 +- t/lib-httpd.sh | 3 +- t/t0000-basic.sh | 4 +- t/t1020-subdirectory.sh | 22 ++-- t/t1303-wacky-config.sh | 6 + t/t1500-rev-parse.sh | 9 +- t/t1501-worktree.sh | 34 +++--- t/t3050-subprojects-fetch.sh | 2 +- t/t3400-rebase.sh | 3 +- t/t3404-rebase-interactive.sh | 3 +- t/t3407-rebase-abort.sh | 33 +++-- t/t3500-cherry.sh | 3 +- t/t5500-fetch-pack.sh | 4 +- t/t5512-ls-remote.sh | 2 +- t/t5516-fetch-push.sh | 6 +- t/t5700-clone-reference.sh | 2 +- t/t5710-info-alternate.sh | 4 +- t/t6000lib.sh | 9 +- t/t6010-merge-base.sh | 9 +- t/t6200-fmt-merge-msg.sh | 6 +- t/t7003-filter-branch.sh | 2 +- t/t7004-tag.sh | 3 +- t/t7010-setup.sh | 2 +- t/t7300-clean.sh | 2 +- t/t7501-commit.sh | 8 +- t/t7504-commit-msg-hook.sh | 23 ++-- t/t7505-prepare-commit-msg-hook.sh | 17 ++- t/t9001-send-email.sh | 5 +- t/t9100-git-svn-basic.sh | 120 +++++++++--------- t/t9101-git-svn-props.sh | 8 +- t/t9102-git-svn-deep-rmdir.sh | 20 ++-- t/t9103-git-svn-tracked-directory-removed.sh | 20 ++-- t/t9104-git-svn-follow-parent.sh | 172 ++++++++++++------------ t/t9105-git-svn-commit-diff.sh | 32 +++--- t/t9106-git-svn-commit-diff-clobber.sh | 56 ++++---- t/t9106-git-svn-dcommit-clobber-series.sh | 30 ++-- t/t9107-git-svn-migrate.sh | 124 +++++++++--------- t/t9108-git-svn-glob.sh | 76 ++++++------ t/t9110-git-svn-use-svm-props.sh | 12 +- t/t9111-git-svn-use-svnsync-props.sh | 12 +- t/t9112-git-svn-md5less-file.sh | 4 +- t/t9113-git-svn-dcommit-new-file.sh | 10 +- t/t9114-git-svn-dcommit-merge.sh | 22 ++-- t/t9115-git-svn-dcommit-funky-renames.sh | 12 +- t/t9116-git-svn-log.sh | 12 +- t/t9117-git-svn-init-clone.sh | 30 ++-- t/t9118-git-svn-funky-branch-names.sh | 24 ++-- t/t9120-git-svn-clone-with-percent-escapes.sh | 6 +- t/t9121-git-svn-fetch-renamed-dir.sh | 12 +- t/t9500-gitweb-standalone-no-errors.sh | 25 ++-- t/test-lib.sh | 22 +++- 55 files changed, 575 insertions(+), 523 deletions(-)