Skip to content

Build in merge

Miklos Vajna git 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest10 patches 17 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/10Move split_cmdline() to alias.calias.c cache.h git.c+55 -530 replies
2/10Move commit_list_count() to commit.cbuiltin-merge-recursive.c commit.c commit.h+9 -80 replies
3/10Move builtin-remote's skip_prefix() to git-compat-util.hbuiltin-remote.c git-compat-util.h parse-options.c+10 -162 replies
4/10Add new test to ensure git-merge handles pull.twohead and pull.octopust/t7601-merge-pull-config.sh+57 -02 replies
5/10parseopt: add a new PARSE_OPT_ARGV0_IS_AN_OPTION optionparse-options.c parse-options.h+6 -00 replies
6/10Move read_cache_unmerged() to read-cache.cbuiltin-read-tree.c cache.h read-cache.c+26 -242 replies
7/10git-fmt-merge-msg: make it useable from other builtinsbuiltin-fmt-merge-msg.c builtin.h+94 -664 replies
8/10Introduce commit_list_append() in commit.ccommit.c commit.h+20 -04 replies
9/10Introduce get_octopus_merge_bases() in commit.ccommit.c commit.h+33 -020 replies
10/10Build in mergeMakefile builtin-merge.c builtin.h +2 more+1150 -10 replies

Reviews trailers per patch

None of the 10 patches has a Reviewed-by or Acked-by.

PatchJohannes SchindelinAndreas Ericsson
1/10
2/10
3/10
4/10
5/10
6/10
7/10Liked-by
8/10
9/10
10/10Mentored-by

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 00/10] Build in merge

This series is a rewrite of git-merge in C.

I already sent a WIP version of this series, it already worked at that time, but I had numerous internal TODOs in the code.

I also tried to use the internal API wherever it was possible to avoid the expensive run_command() calls.

At the moment I am not aware of any bugs in ugly parts in the code, so I would appreciate if I could get some comments (positive or negative) on it.

And yes, I'm aware that it's already late for 1.5.6, I'm sending it out so that I can work on issues pointed out by others in the meantime.

Thanks.

Miklos Vajna (10):
Move split_cmdline() to alias.c
Move commit_list_count() to commit.c
Move builtin-remote's skip_prefix() to git-compat-util.h Add new test to ensure git-merge handles pull.twohead and
pull.octopus
parseopt: add a new PARSE_OPT_ARGV0_IS_AN_OPTION option Move read_cache_unmerged() to read-cache.c
git-fmt-merge-msg: make it useable from other builtins Introduce commit_list_append() in commit.c Introduce get_octopus_merge_bases() in commit.c Build in merge

 Makefile                                      |    2 +-
 alias.c                                       |   54 ++
 builtin-fmt-merge-msg.c                       |  157 ++--
 builtin-merge-recursive.c                     |    8 -
 builtin-merge.c                               | 1147 +++++++++++++++++++++++++
 builtin-read-tree.c                           |   24 -
 builtin-remote.c                              |    6 -
 builtin.h                                     |    4 +
 cache.h                                       |    3 +
 commit.c                                      |   59 ++
 commit.h                                      |    3 +
 git-merge.sh => contrib/examples/git-merge.sh |    0 
 git-compat-util.h                             |    6 +
 git.c                                         |   54 +--
 parse-options.c                               |   19 +-
 parse-options.h                               |    1 +
 read-cache.c                                  |   24 +
 t/t7601-merge-pull-config.sh                  |   57 ++
 18 files changed, 1460 insertions(+), 168 deletions(-)
 create mode 100644 builtin-merge.c
 rename git-merge.sh => contrib/examples/git-merge.sh (100%)
 create mode 100755 t/t7601-merge-pull-config.sh