Skip to content

Respecting core.autocrlf when showing objects

Marius Storm-Olsen git 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 12 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2Add testcases for verifying that staged files in a conflict are CRLF, when core.autocrlf = truet/t6033-merge-crlf.sh+18 -00 replies
2/2Ensure that objects shown in a core.autocrlf = true repo have CRLF EOLsbuiltin-log.c t/t6033-merge-crlf.sh+17 -80 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/2] Respecting core.autocrlf when showing objects

When you use 'git show <rev>:<file>' or 'git show :<stage>:<file>', the objects are shows as they are in the object store, ignoring the core.autocrlf configuration.

This series adds testcases which checks the stage files in a merge conflict, and a fix for the problem.

Running all testcases before and after the fix reveals no regressions:

Before patch series:

    ./aggregate-results.sh test-results/t*-*
    fixed   1
    success 3374
    failed  0
    broken  2
    total   3377

After patch series:

    ./aggregate-results.sh test-results/t*-*
    fixed   1
    success 3377
    failed  0
    broken  2
    total   3380
    rm -f -r 'trash directory' test-results

Marius Storm-Olsen (2):
Add testcases for verifying that staged files in a conflict are CRLF,
when core.autocrlf = true
Ensure that objects shown in a core.autocrlf = true repo have CRLF
EOLs

 builtin-log.c         |   19 ++++++++++++++-----
 t/t6033-merge-crlf.sh |   18 ++++++++++++++++++
 2 files changed, 32 insertions(+), 5 deletions(-)