Skip to content

ixj: Cleanup dead and duplicate code

Richard A. Holden III lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest10 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/10ixj: Remove code duplication for processing codec names.drivers/telephony/ixj.c+36 -880 replies
2/10ixj: Remove dead code in preparation for consolidating duplicate code.drivers/telephony/ixj.c+2 -570 replies
3/10ixj: Unify comments in preparation for pushing duplicate code into a function.drivers/telephony/ixj.c+1 -10 replies
4/10ixj: Consolidate duplicate Ringer array initializers into common functions.drivers/telephony/ixj.c+51 -1170 replies
5/10ixj: Move duplicate code into well named zero_caller_id function.drivers/telephony/ixj.c+13 -390 replies
6/10ixj: Caller ID Refactoringdrivers/telephony/ixj.c+29 -1090 replies
7/10ixj: Refactor DTMF tone settingdrivers/telephony/ixj.c+26 -1040 replies
8/10ixj: update quickly readable comments to match the data initializations.drivers/telephony/ixj.c+11 -110 replies
9/10ixj: Remove unused macro.drivers/telephony/ixj.c+0 -10 replies
10/10ixj: Remove dead code from ifdef IXJ_DYN_ALLOC.drivers/telephony/ixj.c drivers/telephony/ixj.h+0 -660 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 00/10] ixj: Cleanup dead and duplicate code

Cleanup dead code and duplicate code to start simplifying the ixj driver, currently it is around 10000 lines long. This has been built, but I don't have the hardware to test, most changes were fairly mechanical.

Richard A. Holden III (10):
ixj: Remove code duplication for processing codec names.
ixj: Remove dead code in preparation for consolidating duplicate
code.
ixj: Unify comments in preparation for pushing duplicate code into a
function.
ixj: Consolidate duplicate Ringer array initializers into common
functions.
ixj: Move duplicate code into well named zero_caller_id function.
ixj: Caller ID Refactoring
ixj: Refactor DTMF tone setting
ixj: update quickly readable comments to match the data initializations.
ixj: Remove unused macro.
ixj: Remove dead code from ifdef IXJ_DYN_ALLOC.

 drivers/telephony/ixj.c |  752 +++++++++++------------------------------------
 drivers/telephony/ixj.h |    4 -
 2 files changed, 166 insertions(+), 590 deletions(-)