Skip to content

format-patch --cover-letter --in-reply-to

Thomas Rast git 2 versions In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest4 patches 1 replyIn review
  2. v14 patches 1 replySuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4format-patch: threading test reactivationt/t4014-format-patch.sh+103 -390 replies
2/4format-patch: track several referencesbuiltin-log.c log-tree.c revision.h+19 -80 replies
3/4format-patch: thread as reply to cover letter even with in-reply-tobuiltin-log.c t/t4014-format-patch.sh+21 -80 replies
4/4format-patch: support deep threadingDocumentation/config.txt Documentation/git-format-patch.txt builtin-log.c +1 more+170 -60 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 next 0/4] format-patch --cover-letter --in-reply-to
Quoted 11 lines · Daniel Barkalow
Quoted 5 lines · Thomas Rast

Currently, format-patch can only track a single reference (the In-Reply-To:) for each mail. To ensure proper threading, we should list all known references for every mail.

Change the rev_info.ref_message_id field to a string_list

It would be nice to change the field name to "ref_message_ids", which is more likely to suggest that it's a list of ids, rather than a single id stored strangely.

Good point, I changed that.

Quoted 2 lines

Aside from that, parts 2-4 look good to me (I'm not up on reviewing shell code).

Thanks.

I also noticed that there is a textual conflict with 0db5260 (Enable setting attach as the default in .gitconfig for git-format-patch., 2009-02-12), which is already in 'next'. So I rebased the series to 'next'.

Thomas Rast (4):
format-patch: threading test reactivation
format-patch: track several references
format-patch: thread as reply to cover letter even with in-reply-to
format-patch: support deep threading

 Documentation/config.txt           |   10 ++
 Documentation/git-format-patch.txt |   10 ++-
 builtin-log.c                      |   66 ++++++++--
 log-tree.c                         |   11 +-
 revision.h                         |    2 +-
 t/t4014-format-patch.sh            |  265 ++++++++++++++++++++++++++++++------
 6 files changed, 308 insertions(+), 56 deletions(-)