Skip to content

cgroup freezer: Fixes and CHECKPOINTING support

Matt Helsley containers linux-pm 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 26 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4cgroup freezer: Fix buggy resume test for tasks frozen with cgroup freezerinclude/linux/freezer.h kernel/cgroup_freezer.c kernel/power/process.c+12 -612 replies
2/4cgroup freezer: Avoid lazy state changes when convenientkernel/cgroup_freezer.c+4 -10 replies
3/4cgroup freezer: Update stale locking commentskernel/cgroup_freezer.c+13 -80 replies
4/4cgroup freezer: Add CHECKPOINTING state to safeguard container checkpointDocumentation/cgroups/freezer-subsystem.txt checkpoint/checkpoint.c include/linux/freezer.h +1 more+117 -3714 replies

Reviews trailers per patch

2 of 4 patches have a Reviewed-by or Acked-by.

PatchSerge Hallyn
1/4A-b
2/4
3/4
4/4A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/4] cgroup freezer: Fixes and CHECKPOINTING support

This series fixes a bug with the mainline cgroup freezer code and cleans up the cgroup freezer before introducing the new CHECKPOINTING state in the last patch. All but this last patch are independent of checkpoint/restart and hence should be suitable for mainline.

The bug was noticed by Oren Ladaan and allows tasks frozen via the cgroup freezer to be thawed during resume when they should remain frozen. In Oren's checkpoint/restart tree is means that sys_checkpoint() sometimes returns EBUSY even when the cgroup is, in fact, fully frozen. (Workaround: cat /cgroup/foo/freezer.state before doing checkpoint..)

The final patch, which adds the CHECKPOINTING state, incorporates Oren's comments and should fix the lockdep bug he posted too. I haven't tested this latest version yet myself and I have a few things to attend to before I can get to it so I'm posting this for initial review now. I believe this resolves all the pending comments I've seen about the CHECKPOINTING state.

Cheers,
-Matt Helsley

Matt Helsley (4):
cgroup freezer: Fix buggy resume test for tasks frozen with cgroup
freezer
cgroup freezer: Avoid lazy state changes when convenient cgroup freezer: Update stale locking comments
cgroup freezer: Add CHECKPOINTING state to safeguard container
checkpoint

 Documentation/cgroups/freezer-subsystem.txt |   10 ++
 checkpoint/checkpoint.c                     |    8 +-
 include/linux/freezer.h                     |   15 ++-
 kernel/cgroup_freezer.c                     |  163 +++++++++++++++++++--------
 kernel/power/process.c                      |    2 +-
 5 files changed, 146 insertions(+), 52 deletions(-)