cgroup freezer: Fixes and CHECKPOINTING support
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest4 patches 26 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/4 | cgroup freezer: Fix buggy resume test for tasks frozen with cgroup freezerinclude/ kernel/ kernel/ | +12 | 12 replies | |
| 2/4 | cgroup freezer: Avoid lazy state changes when convenientkernel/ | +4 | 0 replies | |
| 3/4 | cgroup freezer: Update stale locking commentskernel/ | +13 | 0 replies | |
| 4/4 | cgroup freezer: Add CHECKPOINTING state to safeguard container checkpointDocumentation/ checkpoint/ include/ +1 more | +117 | 14 replies |
Reviews trailers per patch
2 of 4 patches have a Reviewed-by or Acked-by.
| Patch | Serge Hallyn |
|---|---|
| 1/4 | A-b |
| 2/4 | |
| 3/4 | |
| 4/4 | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 0/4] cgroup freezer: Fixes and CHECKPOINTING support
This series fixes a bug with the mainline cgroup freezer code and cleans up the cgroup freezer before introducing the new CHECKPOINTING state in the last patch. All but this last patch are independent of checkpoint/restart and hence should be suitable for mainline.
The bug was noticed by Oren Ladaan and allows tasks frozen via the cgroup freezer to be thawed during resume when they should remain frozen. In Oren's checkpoint/restart tree is means that sys_checkpoint() sometimes returns EBUSY even when the cgroup is, in fact, fully frozen. (Workaround: cat /cgroup/foo/freezer.state before doing checkpoint..)
The final patch, which adds the CHECKPOINTING state, incorporates Oren's comments and should fix the lockdep bug he posted too. I haven't tested this latest version yet myself and I have a few things to attend to before I can get to it so I'm posting this for initial review now. I believe this resolves all the pending comments I've seen about the CHECKPOINTING state.
Cheers,
-Matt Helsley
Matt Helsley (4):
cgroup freezer: Fix buggy resume test for tasks frozen with cgroup
freezer
cgroup freezer: Avoid lazy state changes when convenient cgroup freezer: Update stale locking comments
cgroup freezer: Add CHECKPOINTING state to safeguard container
checkpoint
Documentation/cgroups/freezer-subsystem.txt | 10 ++ checkpoint/checkpoint.c | 8 +- include/linux/freezer.h | 15 ++- kernel/cgroup_freezer.c | 163 +++++++++++++++++++-------- kernel/power/process.c | 2 +- 5 files changed, 146 insertions(+), 52 deletions(-)