Skip to content

convert ftrace syscalls to TRACE_EVENT

Jason Baron lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 12 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2allow TP_printk() to have no argsinclude/trace/ftrace.h+1 -10 replies
2/2convert to syscall tracepointsarch/x86/kernel/ptrace.c include/asm-generic/syscall.h include/trace/events/syscalls.h +4 more+4317 -25412 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/2] convert ftrace syscalls to TRACE_EVENT

hi,

I brought this up for as RFC before, and people were agreed in principal to this idea. There are a number of advantages to having the syscall tracing implemented as an event:

-can toggle on/off individual syscalls
-as a non-dedicated tracer, it can intermix with other tracing data -by using tracepoints other infrastructures can tie into this implementation -ability to print flag names and not just bits

In terms of the implementation, I've introduced a new 'trace_syscalls' enabled flag in the <debugfs>/tracing/ directory to toggle the TIF_SYSCALL_FTRACE.
so: echo 1 > trace_syscalls to enable, echo 0 > trace_syscalls disable.

The implementation is still a bit rough, but I wanted to make sure I was on the right track before spending more time on this. I've showed an example of printing out a flag using a 'clock_id_toname()' to macro. Steven's print_flags() addition, should make pretty printing flag names much easier.

I believe that this current patch covers the functionality of the current ftrace syscall tracer minus priting variable names and types, which I could add....thus, I hope it can be merged in this state, and we can add pretty printing features over time?

thanks,

-Jason

Jason Baron (2):
-allow TP_printk() to have no args
-syscall tracepoints

 arch/x86/kernel/ptrace.c        |    8 +-
 include/asm-generic/syscall.h   |    3 +
 include/trace/events/syscalls.h | 4202 +++++++++++++++++++++++++++++++++++++++
 include/trace/ftrace.h          |    2 +-
 include/trace/syscall.h         |    6 +
 kernel/trace/Makefile           |    1 -
 kernel/trace/trace.c            |  101 +
 kernel/trace/trace_syscalls.c   |  250 ---
 8 files changed, 4318 insertions(+), 255 deletions(-)
 create mode 100644 include/trace/events/syscalls.h
 delete mode 100644 kernel/trace/trace_syscalls.c