Skip to content

add syscall tracepoints

Jason Baron lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest7 patches 24 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7add syscall tracepointsarch/x86/kernel/ftrace.c+16 -01 reply
2/7add syscall tracepointsarch/x86/kernel/ftrace.c+5 -32 replies
3/7add syscall tracepointsinclude/linux/tracepoint.h+23 -48 replies
4/7add syscall tracepointsarch/x86/kernel/ptrace.c include/trace/syscall.h kernel/tracepoint.c+60 -24 replies
5/7add syscall tracepointsarch/x86/include/asm/ftrace.h+2 -24 replies
6/7add syscall tracepointskernel/trace/trace_events.c+19 -102 replies
7/7add syscall tracepointsinclude/linux/syscalls.h include/trace/syscall.h kernel/trace/trace_syscalls.c+153 -1010 replies

Reviews trailers per patch

None of the 7 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchFrederic Weisbecker
SeriesA-b
1/7
2/7
3/7
4/7
5/7
6/7
7/7

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/7] add syscall tracepoints

hi,

The following is an implementation of Frederic's syscall tracer on top of tracepoints. It adds the ability to toggle the entry/exit of each syscall via the standard events/syscalls/syscall_blah/enable interface. The implementation is done by adding 2 tracepoints. One on entry and one for exit.

This implementation required a few 'core' api changes. I've added 'DECLARE_TRACE_REG()' macro which takes a register and and an unregister function as arguments. This allowed me to toggle the ftrace tif flag when the first tracepoint callback is added and the last is removed. Current callers of 'DECLARE_TRACE()' are not impacted.

Another change was to call arch_init_ftrace_syscalls via an 'arch_initall'. In this implmentation I needed to access the syscalls_metadata structure at runtime in order to determine which syscalls were 'traceable'. Although the implementation uses SYSCALL_DEFINE() to set up the the trace events, for some reason at runtime there is no syscalls_metadata, associated with some of the SYSCALL_DEFINE() calls. I'm not quite sure why that is. However, by calling arch_init_ftrace_syscalls() at boot I can make sure the lists are in sync.

thanks,

-Jason

 arch/x86/include/asm/ftrace.h |    4 +-
 arch/x86/kernel/ftrace.c      |   24 +++++-
 arch/x86/kernel/ptrace.c      |    6 +-
 include/linux/syscalls.h      |   63 +++++++++++++++
 include/linux/tracepoint.h    |   27 ++++++-
 include/trace/syscall.h       |   37 +++++++---
 kernel/trace/trace_events.c   |   29 +++++---
 kernel/trace/trace_syscalls.c |  172 +++++++++++++++++++----------------------
 kernel/tracepoint.c           |   38 +++++++++
 9 files changed, 278 insertions(+), 122 deletions(-)