Skip to content

fix gpio-keys debouncing and timer sleep issues

Jani Nikula linux-input lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 4 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2Revert "Input: gpio-keys - change timer to workqueue"drivers/input/keyboard/gpio_keys.c+20 -120 replies
2/2input: gpio-keys: avoid possibility of sleeping in timer functiondrivers/input/keyboard/gpio_keys.c+12 -51 reply

Reviews trailers per patch

None of the 2 patches has a Reviewed-by or Acked-by.

PatchAlek Du
1/2
2/2T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/2] fix gpio-keys debouncing and timer sleep issues

Alek, someone might depend on how debouncing worked before, so let's not break it. I, for one, am looking at using this in the future, and would want this to work as it was before.

Why don't we fix this instead of debating? For simplicity, here's first a revert of the original patch and then a fix to the sleep issue. Unfortunately, I do not have the equipment to properly test this right now.

Could you please review and test this if you have the equipment? Add your signed-off-by and comments, of course. Would that be okay?

BR,
Jani.

Jani Nikula (2):
Revert "Input: gpio-keys - change timer to workqueue"
input: gpio-keys: avoid possibility of sleeping in timer function

 drivers/input/keyboard/gpio_keys.c |   33 ++++++++++++++++++++++++---------
 1 files changed, 24 insertions(+), 9 deletions(-)