Skip to content

Remove unnecessary semicolons

Joe Perches alsa-devel ath9k-devel autofs kvm linux-btrfs linux-ext4 linux-fbdev linux-ide linux-media linux-mips linux-nfs linux-scsi linux-spi linux-um linux-wireless linuxppc-dev lkml lm-sensors netdev ocfs2-devel virtualization xen-devel 1 version Applied

Status from this message: Thanks, applied.

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest62 patches 34 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/62arch/arm: Remove unnecessary semicolonsarch/arm/mach-at91/at91cap9_devices.c arch/arm/mach-at91/at91sam9rl_devices.c arch/arm/mach-w90x900/w90p910.c +1 more+4 -40 replies
2/62arch/ia64: Remove unnecessary semicolonsarch/ia64/kernel/esi.c arch/ia64/kvm/process.c arch/ia64/kvm/vcpu.c +1 more+7 -70 replies
3/62arch/m68knommu/kernel/time.c: Remove unnecessary semicolonsarch/m68knommu/kernel/time.c+1 -11 reply
4/62arch/mips/kernel/vpe.c: Remove unnecessary semicolonsarch/mips/kernel/vpe.c+1 -11 reply
5/62arch/powerpc: Remove unnecessary semicolonsarch/powerpc/mm/tlb_hash64.c arch/powerpc/oprofile/cell/vma_map.c arch/powerpc/platforms/powermac/cpufreq_64.c +4 more+7 -81 reply
6/62arch/s390/hypfs/inode.c: Remove unnecessary semicolonsarch/s390/hypfs/inode.c+1 -10 replies
7/62arch/s390/kvm/interrupt.c: Remove unnecessary semicolonsarch/s390/kvm/interrupt.c+1 -10 replies
8/62arch/sh/boards/mach-se/7206/io.c: Remove unnecessary semicolonsarch/sh/boards/mach-se/7206/io.c+1 -10 replies
9/62arch/sparc/kernel/irq_64.c: Remove unnecessary semicolonsarch/sparc/kernel/irq_64.c+1 -10 replies
10/62arch/um/drivers/net_kern.c: Remove unnecessary semicolonsarch/um/drivers/net_kern.c+1 -10 replies
11/62arch/x86/kernel/ds.c: Remove unnecessary semicolonsarch/x86/kernel/ds.c+1 -11 reply
12/62drivers/ata: Remove unnecessary semicolonsdrivers/ata/pata_octeon_cf.c drivers/ata/sata_inic162x.c+2 -21 reply
13/62drivers/block: Remove unnecessary semicolonsdrivers/block/DAC960.c drivers/block/swim3.c+3 -30 replies
14/62drivers/char/epca.c: Remove unnecessary semicolonsdrivers/char/epca.c+1 -18 replies
15/62drivers/dma/fsldma.c: Remove unnecessary semicolonsdrivers/dma/fsldma.c+1 -11 reply
16/62drivers/dma: Remove unnecessary semicolonsdrivers/dma/dmatest.c drivers/dma/mv_xor.c+2 -20 replies
17/62drivers/gpu/drm: Remove unnecessary semicolonsdrivers/gpu/drm/i915/intel_dp.c drivers/gpu/drm/radeon/r300.c+3 -30 replies
18/62drivers/hwmon/sht15.c: Remove unnecessary semicolonsdrivers/hwmon/sht15.c+1 -11 reply
19/62drivers/ide: Remove unnecessary semicolonsdrivers/ide/ide-probe.c drivers/ide/umc8672.c+3 -30 replies
20/62drivers/isdn/capi/capiutil.c: Remove unnecessary semicolonsdrivers/isdn/capi/capiutil.c+1 -10 replies
21/62drivers/macintosh/rack-meter.c: Remove unnecessary semicolonsdrivers/macintosh/rack-meter.c+1 -10 replies
22/62drivers/media/video/cx18/cx18-fileops.c: Remove unnecessary semicolonsdrivers/media/video/cx18/cx18-fileops.c+1 -15 replies
23/62drivers/media/video/ivtv/ivtv-driver.c: Remove unnecessary semicolonsdrivers/media/video/ivtv/ivtv-driver.c+1 -10 replies
24/62drivers/media: Remove unnecessary semicolonsdrivers/media/dvb/b2c2/flexcop-fe-tuner.c drivers/media/dvb/dvb-usb/dib0700_devices.c drivers/media/dvb/frontends/cx24123.c +4 more+8 -80 replies
25/62drivers/mfd/twl4030-irq.c: Remove unnecessary semicolonsdrivers/mfd/twl4030-irq.c+1 -10 replies
26/62drivers/mmc/host/imxmmc.c: Remove unnecessary semicolonsdrivers/mmc/host/imxmmc.c+1 -13 replies
27/62drivers/net/wireless/ath/ath9k: Remove unnecessary semicolonsdrivers/net/wireless/ath/ath9k/eeprom.c drivers/net/wireless/ath/ath9k/hw.c+1 -30 replies
28/62drivers/net/bnx2x_link.c: Remove unnecessary semicolonsdrivers/net/bnx2x_link.c+1 -10 replies
29/62drivers/net/igb/igb_main.c: Remove unnecessary semicolonsdrivers/net/igb/igb_main.c+2 -20 replies
30/62drivers/net/qlge/qlge_main.c: Remove unnecessary semicolonsdrivers/net/qlge/qlge_main.c+2 -22 replies
31/62drivers/net/skfp: Remove unnecessary semicolonsdrivers/net/skfp/pcmplc.c drivers/net/skfp/pmf.c+5 -50 replies
32/62drivers/net/skge.c: Remove unnecessary semicolonsdrivers/net/skge.c+1 -10 replies
33/62drivers/net/sky2.c: Remove unnecessary semicolonsdrivers/net/sky2.c+1 -10 replies
34/62drivers/net: Remove unnecessary semicolonsdrivers/net/arcnet/arc-rawmode.c drivers/net/arcnet/capmode.c drivers/net/gianfar_ethtool.c +6 more+14 -160 replies
35/62drivers/pci/pcie/aer/ecrc.c: Remove unnecessary semicolonsdrivers/pci/pcie/aer/ecrc.c+1 -12 replies
36/62drivers/pcmcia/pcmcia_resource.c: Remove unnecessary semicolonsdrivers/pcmcia/pcmcia_resource.c+1 -10 replies
37/62drivers/regulator/pcf50633-regulator.c: Remove unnecessary semicolonsdrivers/regulator/pcf50633-regulator.c+1 -11 reply
38/62drivers/rtc/rtc-omap.c: Remove unnecessary semicolonsdrivers/rtc/rtc-omap.c+1 -10 replies
39/62drivers/s390/block/dasd_eckd.c: Remove unnecessary semicolonsdrivers/s390/block/dasd_eckd.c+1 -10 replies
40/62drivers/s390/net/netiucv.c: Remove unnecessary semicolonsdrivers/s390/net/netiucv.c+1 -10 replies
41/62drivers/s390/scsi/zfcp_scsi.c: Remove unnecessary semicolonsdrivers/s390/scsi/zfcp_scsi.c+1 -11 reply
42/62drivers/scsi/bnx2i/bnx2i_hwi.c: Remove unnecessary semicolonsdrivers/scsi/bnx2i/bnx2i_hwi.c+1 -10 replies
43/62include/scsi/fc/fc_fc2.h: Remove unnecessary semicolonsinclude/scsi/fc/fc_fc2.h+1 -20 replies
44/62drivers/scsi/lpfc/lpfc_ct.c: Remove unnecessary semicolonsdrivers/scsi/lpfc/lpfc_ct.c+1 -10 replies
45/62drivers/spi: Remove unnecessary semicolonsdrivers/spi/omap_uwire.c drivers/spi/spi_s3c24xx.c+2 -20 replies
46/62drivers/staging: Remove unnecessary semicolonsdrivers/staging/comedi/drivers/addi-data/APCI1710_Tor.c drivers/staging/comedi/drivers/addi-data/hwdrv_apci1500.c drivers/staging/comedi/drivers/addi-data/hwdrv_apci1516.c +17 more+26 -270 replies
47/62drivers/usb: Remove unnecessary semicolonsdrivers/usb/class/cdc-wdm.c drivers/usb/serial/spcp8x5.c+1 -30 replies
48/62drivers/uwb/i1480/i1480u-wlp/netdev.c: Remove unnecessary semicolonsdrivers/uwb/i1480/i1480u-wlp/netdev.c+1 -10 replies
49/62drivers/video/cfbcopyarea.c: Remove unnecessary semicolonsdrivers/video/cfbcopyarea.c+1 -10 replies
50/62drivers/video/imxfb.c: Remove unnecessary semicolonsdrivers/video/imxfb.c+1 -11 reply
51/62drivers/video/s3c2410fb.c: Remove unnecessary semicolonsdrivers/video/s3c2410fb.c+1 -10 replies
52/62drivers/watchdog/bcm47xx_wdt.c: Remove unnecessary semicolonsdrivers/watchdog/bcm47xx_wdt.c+1 -11 reply
53/62drivers/xen/balloon.c: Remove unnecessary semicolonsdrivers/xen/balloon.c+1 -10 replies
54/62fs/autofs/dirhash.c: Remove unnecessary semicolonsfs/autofs/dirhash.c+1 -10 replies
55/62fs/btrfs/tree-log.c: Remove unnecessary semicolonsfs/btrfs/tree-log.c+1 -10 replies
56/62fs/cifs/cifs_dfs_ref.c: Remove unnecessary semicolonsfs/cifs/cifs_dfs_ref.c+1 -12 replies
57/62fs/ext4/mballoc.c: Remove unnecessary semicolonsfs/ext4/mballoc.c+1 -11 reply
58/62fs/nfs/callback_xdr.c: Remove unnecessary semicolonsfs/nfs/callback_xdr.c+1 -10 replies
59/62fs/ocfs2/quota_global.c: Remove unnecessary semicolonsfs/ocfs2/quota_global.c+1 -11 reply
60/62kernel/trace/trace_hw_branches.c: Remove unnecessary semicolonskernel/trace/trace_hw_branches.c+1 -10 replies
61/62net/wireless/wext-compat.c: Remove unnecessary semicolonsnet/wireless/wext-compat.c+1 -10 replies
62/62sound: Remove unnecessary semicolonssound/oss/sys_timer.c sound/soc/codecs/wm9081.c sound/soc/pxa/pxa-ssp.c +1 more+3 -61 reply

Reviews trailers per patch

9 of 62 patches have a Reviewed-by or Acked-by.

PatchAndy WallsChristof SchmittDavid S. MillerSascha HauerMark BrownGeoff LevandAndrew PattersonPavel PisaMark Fasheh
1/62
2/62
3/62
4/62
5/62A-b
6/62
7/62
8/62
9/62
10/62
11/62
12/62
13/62
14/62
15/62
16/62
17/62
18/62
19/62
20/62
21/62
22/62A-b A-b
23/62
24/62
25/62
26/62A-b
27/62
28/62
29/62
30/62A-b
31/62
32/62
33/62
34/62
35/62A-b
36/62
37/62
38/62
39/62
40/62
41/62A-b
42/62
43/62
44/62
45/62
46/62
47/62
48/62
49/62
50/62A-b
51/62
52/62
53/62
54/62
55/62
56/62
57/62
58/62
59/62A-b
60/62
61/62
62/62A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 9 reviewers.

Read the v1 thread

Cover letter [PATCH 00/62] Remove unnecessary semicolons

Found by script
#! /bin/bash

from=";\s*;\s*\n"
to=";\n"

for file in $(grep -rP --include=*.[ch] -li $from *) ; do

    perl -i -e \
	"local $/; while(<>) { s/$from/$to/g; print; }" $file

done

Some false positives removed manually

Joe Perches (62):
arch/arm: Remove unnecessary semicolons
arch/ia64: Remove unnecessary semicolons arch/m68knommu/kernel/time.c: Remove unnecessary semicolons arch/mips/kernel/vpe.c: Remove unnecessary semicolons arch/powerpc: Remove unnecessary semicolons arch/s390/hypfs/inode.c: Remove unnecessary semicolons arch/s390/kvm/interrupt.c: Remove unnecessary semicolons arch/sh/boards/mach-se/7206/io.c: Remove unnecessary semicolons arch/sparc/kernel/irq_64.c: Remove unnecessary semicolons arch/um/drivers/net_kern.c: Remove unnecessary semicolons arch/x86/kernel/ds.c: Remove unnecessary semicolons drivers/ata: Remove unnecessary semicolons
drivers/block: Remove unnecessary semicolons drivers/char/epca.c: Remove unnecessary semicolons drivers/dma/fsldma.c: Remove unnecessary semicolons drivers/dma: Remove unnecessary semicolons drivers/gpu/drm: Remove unnecessary semicolons drivers/hwmon/sht15.c: Remove unnecessary semicolons drivers/ide: Remove unnecessary semicolons drivers/isdn/capi/capiutil.c: Remove unnecessary semicolons drivers/macintosh/rack-meter.c: Remove unnecessary semicolons drivers/media/video/cx18/cx18-fileops.c: Remove unnecessary semicolons drivers/media/video/ivtv/ivtv-driver.c: Remove unnecessary semicolons drivers/media: Remove unnecessary semicolons drivers/mfd/twl4030-irq.c: Remove unnecessary semicolons drivers/mmc/host/imxmmc.c: Remove unnecessary semicolons drivers/net/wireless/ath/ath9k: Remove unnecessary semicolons drivers/net/bnx2x_link.c: Remove unnecessary semicolons drivers/net/igb/igb_main.c: Remove unnecessary semicolons drivers/net/qlge/qlge_main.c: Remove unnecessary semicolons drivers/net/skfp: Remove unnecessary semicolons drivers/net/skge.c: Remove unnecessary semicolons drivers/net/sky2.c: Remove unnecessary semicolons drivers/net: Remove unnecessary semicolons drivers/pci/pcie/aer/ecrc.c: Remove unnecessary semicolons drivers/pcmcia/pcmcia_resource.c: Remove unnecessary semicolons drivers/regulator/pcf50633-regulator.c: Remove unnecessary semicolons drivers/rtc/rtc-omap.c: Remove unnecessary semicolons drivers/s390/block/dasd_eckd.c: Remove unnecessary semicolons drivers/s390/net/netiucv.c: Remove unnecessary semicolons drivers/s390/scsi/zfcp_scsi.c: Remove unnecessary semicolons drivers/scsi/bnx2i/bnx2i_hwi.c: Remove unnecessary semicolons include/scsi/fc/fc_fc2.h: Remove unnecessary semicolons drivers/scsi/lpfc/lpfc_ct.c: Remove unnecessary semicolons drivers/spi: Remove unnecessary semicolons drivers/staging: Remove unnecessary semicolons drivers/usb: Remove unnecessary semicolons drivers/uwb/i1480/i1480u-wlp/netdev.c: Remove unnecessary semicolons drivers/video/cfbcopyarea.c: Remove unnecessary semicolons drivers/video/imxfb.c: Remove unnecessary semicolons drivers/video/s3c2410fb.c: Remove unnecessary semicolons drivers/watchdog/bcm47xx_wdt.c: Remove unnecessary semicolons drivers/xen/balloon.c: Remove unnecessary semicolons fs/autofs/dirhash.c: Remove unnecessary semicolons fs/btrfs/tree-log.c: Remove unnecessary semicolons fs/cifs/cifs_dfs_ref.c: Remove unnecessary semicolons fs/ext4/mballoc.c: Remove unnecessary semicolons fs/nfs/callback_xdr.c: Remove unnecessary semicolons fs/ocfs2/quota_global.c: Remove unnecessary semicolons kernel/trace/trace_hw_branches.c: Remove unnecessary semicolons net/wireless/wext-compat.c: Remove unnecessary semicolons
sound: Remove unnecessary semicolons

 arch/arm/mach-at91/at91cap9_devices.c              |    2 +-
 arch/arm/mach-at91/at91sam9rl_devices.c            |    2 +-
 arch/arm/mach-w90x900/w90p910.c                    |    2 +-
 arch/arm/plat-mxc/irq.c                            |    2 +-
 arch/ia64/kernel/esi.c                             |    2 +-
 arch/ia64/kvm/process.c                            |    6 +++---
 arch/ia64/kvm/vcpu.c                               |    2 +-
 arch/ia64/kvm/vtlb.c                               |    4 ++--
 arch/m68knommu/kernel/time.c                       |    2 +-
 arch/mips/kernel/vpe.c                             |    2 +-
 arch/powerpc/mm/tlb_hash64.c                       |    2 +-
 arch/powerpc/oprofile/cell/vma_map.c               |    2 +-
 arch/powerpc/platforms/powermac/cpufreq_64.c       |    2 +-
 arch/powerpc/platforms/powermac/pic.c              |    2 +-
 arch/powerpc/platforms/ps3/system-bus.c            |    1 -
 arch/powerpc/sysdev/fsl_rio.c                      |    2 +-
 arch/powerpc/sysdev/ppc4xx_pci.c                   |    4 ++--
 arch/s390/hypfs/inode.c                            |    2 +-
 arch/s390/kvm/interrupt.c                          |    2 +-
 arch/sh/boards/mach-se/7206/io.c                   |    2 +-
 arch/sparc/kernel/irq_64.c                         |    2 +-
 arch/um/drivers/net_kern.c                         |    2 +-
 arch/x86/kernel/ds.c                               |    2 +-
 drivers/ata/pata_octeon_cf.c                       |    2 +-
 drivers/ata/sata_inic162x.c                        |    2 +-
 drivers/block/DAC960.c                             |    4 ++--
 drivers/block/swim3.c                              |    2 +-
 drivers/char/epca.c                                |    2 +-
 drivers/dma/dmatest.c                              |    2 +-
 drivers/dma/fsldma.c                               |    2 +-
 drivers/dma/mv_xor.c                               |    2 +-
 drivers/gpu/drm/i915/intel_dp.c                    |    2 +-
 drivers/gpu/drm/radeon/r300.c                      |    4 ++--
 drivers/hwmon/sht15.c                              |    2 +-
 drivers/ide/ide-probe.c                            |    2 +-
 drivers/ide/umc8672.c                              |    4 ++--
 drivers/isdn/capi/capiutil.c                       |    2 +-
 drivers/macintosh/rack-meter.c                     |    2 +-
 drivers/media/dvb/b2c2/flexcop-fe-tuner.c          |    2 +-
 drivers/media/dvb/dvb-usb/dib0700_devices.c        |    2 +-
 drivers/media/dvb/frontends/cx24123.c              |    2 +-
 drivers/media/dvb/frontends/dib0070.c              |    2 +-
 drivers/media/dvb/frontends/stv0900_sw.c           |    2 +-
 drivers/media/video/cx18/cx18-fileops.c            |    2 +-
 drivers/media/video/cx231xx/cx231xx-video.c        |    4 ++--
 drivers/media/video/cx23885/cx23885.h              |    2 +-
 drivers/media/video/ivtv/ivtv-driver.c             |    2 +-
 drivers/mfd/twl4030-irq.c                          |    2 +-
 drivers/mmc/host/imxmmc.c                          |    2 +-
 drivers/net/arcnet/arc-rawmode.c                   |    1 -
 drivers/net/arcnet/capmode.c                       |    1 -
 drivers/net/bnx2x_link.c                           |    2 +-
 drivers/net/gianfar_ethtool.c                      |    2 +-
 drivers/net/ibm_newemac/core.c                     |    8 ++++----
 drivers/net/igb/igb_main.c                         |    4 ++--
 drivers/net/ll_temac_main.c                        |    2 +-
 drivers/net/ni52.c                                 |    4 ++--
 drivers/net/qlge/qlge_main.c                       |    4 ++--
 drivers/net/skfp/pcmplc.c                          |    2 +-
 drivers/net/skfp/pmf.c                             |    8 ++++----
 drivers/net/skge.c                                 |    2 +-
 drivers/net/sky2.c                                 |    2 +-
 drivers/net/vxge/vxge-config.h                     |    2 +-
 drivers/net/vxge/vxge-main.c                       |    2 +-
 drivers/net/wireless/ath/ath9k/eeprom.c            |    2 --
 drivers/net/wireless/ath/ath9k/hw.c                |    2 +-
 drivers/net/wireless/iwmc3200wifi/rx.c             |    8 ++++----
 drivers/pci/pcie/aer/ecrc.c                        |    2 +-
 drivers/pcmcia/pcmcia_resource.c                   |    2 +-
 drivers/regulator/pcf50633-regulator.c             |    2 +-
 drivers/rtc/rtc-omap.c                             |    2 +-
 drivers/s390/block/dasd_eckd.c                     |    2 +-
 drivers/s390/net/netiucv.c                         |    2 +-
 drivers/s390/scsi/zfcp_scsi.c                      |    2 +-
 drivers/scsi/bnx2i/bnx2i_hwi.c                     |    2 +-
 drivers/scsi/lpfc/lpfc_ct.c                        |    2 +-
 drivers/spi/omap_uwire.c                           |    2 +-
 drivers/spi/spi_s3c24xx.c                          |    2 +-
 .../comedi/drivers/addi-data/APCI1710_Tor.c        |    2 +-
 .../comedi/drivers/addi-data/hwdrv_apci1500.c      |    2 +-
 .../comedi/drivers/addi-data/hwdrv_apci1516.c      |    2 +-
 .../comedi/drivers/addi-data/hwdrv_apci3501.c      |    2 +-
 drivers/staging/comedi/drivers/amplc_pci230.c      |    2 +-
 drivers/staging/comedi/drivers/comedi_bond.c       |    2 +-
 drivers/staging/go7007/go7007-driver.c             |    2 +-
 drivers/staging/otus/80211core/cmmsta.c            |    2 +-
 drivers/staging/otus/hal/hpmain.c                  |    2 +-
 drivers/staging/rt2860/common/cmm_data_2860.c      |    8 ++++----
 drivers/staging/rt2860/rt_linux.c                  |    2 +-
 drivers/staging/rt2860/rtmp.h                      |    3 +--
 drivers/staging/rt2860/sta/aironet.c               |    2 +-
 drivers/staging/rtl8187se/r8185b_init.c            |    2 +-
 drivers/staging/rtl8192su/ieee80211/ieee80211_tx.c |    2 +-
 drivers/staging/rtl8192su/r8192U_core.c            |    6 +++---
 drivers/staging/rtl8192su/r819xU_phy.c             |    2 +-
 drivers/staging/vt6655/card.c                      |    2 +-
 drivers/staging/vt6655/iwctl.c                     |    2 +-
 drivers/staging/vt6655/wpa2.c                      |    4 ++--
 drivers/usb/class/cdc-wdm.c                        |    2 --
 drivers/usb/serial/spcp8x5.c                       |    2 +-
 drivers/uwb/i1480/i1480u-wlp/netdev.c              |    2 +-
 drivers/video/cfbcopyarea.c                        |    2 +-
 drivers/video/imxfb.c                              |    2 +-
 drivers/video/s3c2410fb.c                          |    2 +-
 drivers/watchdog/bcm47xx_wdt.c                     |    2 +-
 drivers/xen/balloon.c                              |    2 +-
 fs/autofs/dirhash.c                                |    2 +-
 fs/btrfs/tree-log.c                                |    2 +-
 fs/cifs/cifs_dfs_ref.c                             |    2 +-
 fs/ext4/mballoc.c                                  |    2 +-
 fs/nfs/callback_xdr.c                              |    2 +-
 fs/ocfs2/quota_global.c                            |    2 +-
 include/scsi/fc/fc_fc2.h                           |    3 +--
 kernel/trace/trace_hw_branches.c                   |    2 +-
 net/wireless/wext-compat.c                         |    2 +-
 sound/oss/sys_timer.c                              |    3 ---
 sound/soc/codecs/wm9081.c                          |    2 +-
 sound/soc/pxa/pxa-ssp.c                            |    2 +-
 sound/soc/s3c24xx/s3c24xx_uda134x.c                |    2 +-
 119 files changed, 139 insertions(+), 151 deletions(-)