Skip to content

8xxx dma updates

Peter Tyser u-boot 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v2 Latest12 patches 0 repliesNew

Changes in v2 from the cover letter

- Add 83xx patches, these were previously submitted as an RFC
- Add a CONFIG_FSL_DMA check to include/asm-ppc/config.h
- Use phys_addr_t and phys_size_t arguments to dmacpy()

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/1285xx, 86xx: Break out DMA code to a common filecpu/mpc85xx/cpu.c cpu/mpc86xx/cpu.c drivers/dma/Makefile +4 more+102 -1021 reply
2/12fsl_dma: Add bitfield definitions for common registersdrivers/dma/fsl_dma.c include/asm-ppc/fsl_dma.h+52 -61 reply
3/12fsl_dma: Use proper I/O access functionsdrivers/dma/fsl_dma.c+18 -141 reply
4/12fsl_dma: Add support for arbitrarily large transfersdrivers/dma/fsl_dma.c+28 -121 reply
5/12fsl_dma: Fix Channel Start bug in dma_check()drivers/dma/fsl_dma.c+1 -11 reply
6/128xxx: Rename dma_xfer() to dmacpy()board/mpc8540eval/mpc8540eval.c board/sbc8560/sbc8560.c cpu/mpc83xx/cpu.c +3 more+55 -591 reply
7/12fsl_dma: Move dma function prototypes to common header filecpu/mpc85xx/ddr-gen1.c include/asm-ppc/fsl_dma.h+5 -41 reply
8/1285xx, 86xx: Move dma_init() call to common codeboard/mpc8540eval/mpc8540eval.c board/sbc8560/sbc8560.c cpu/mpc85xx/cpu_init.c +2 more+8 -51 reply
9/12fsl_dma: Break out common memory initialization functionboard/mpc8540eval/mpc8540eval.c board/sbc8560/sbc8560.c cpu/mpc85xx/ddr-gen1.c +2 more+38 -871 reply
10/12fsl_dma: Make DMA transactions snoopabledrivers/dma/fsl_dma.c+2 -21 reply
11/1283xx: Replace CONFIG_ECC_INIT_VIA_DDRC referencesboard/freescale/mpc8360emds/mpc8360emds.c board/freescale/mpc8360erdk/mpc8360erdk.c board/freescale/mpc837xemds/mpc837xemds.c +3 more+11 -113 replies
12/1283xx: Add support for fsl_dma drivercpu/mpc83xx/cpu.c cpu/mpc83xx/spd_sdram.c drivers/dma/fsl_dma.c +4 more+96 -1993 replies
12/1283xx: Add support for fsl_dma driver+0 -00 replies
12/1283xx: Add support for fsl_dma driver+0 -02 replies

Reviews trailers per patch

3 of 14 patches have a Reviewed-by or Acked-by.

PatchIra W. Snyder
1/12
2/12
3/12
4/12
5/12
6/12
7/12
8/12
9/12
10/12
11/12
12/12R-b T-b
12/12R-b T-b
12/12R-b T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [U-Boot] [PATCH v2 00/12] 8xxx dma updates

This patch series attempts to clean up the DMA implementation for the 83xx, 85xx, and 86xx architectures. The changes include:
- consolidate 83xx, 85xx, and 86xx structures and code
- add defines for bitfields
- use proper IO accessors
- add support for arbitrarily large transfer sizes
- rename dma_xfer() to dmacpy() and make dmacpy's prototype similar to memcpy()

Changes since v1:
- Add 83xx patches, these were previously submitted as an RFC
- Add a CONFIG_FSL_DMA check to include/asm-ppc/config.h
- Use phys_addr_t and phys_size_t arguments to dmacpy()

I've tested the code on MPC8572 and MPC8640-based boards. Ira Snyder tested on an 83xx-based board. I compile-tested all 8xxx boards.

Peter Tyser (12):
85xx, 86xx: Break out DMA code to a common file
fsl_dma: Add bitfield definitions for common registers
fsl_dma: Use proper I/O access functions
fsl_dma: Add support for arbitrarily large transfers
fsl_dma: Fix Channel Start bug in dma_check() 8xxx: Rename dma_xfer() to dmacpy()
fsl_dma: Move dma function prototypes to common header file 85xx, 86xx: Move dma_init() call to common code
fsl_dma: Break out common memory initialization function
fsl_dma: Make DMA transactions snoopable
83xx: Replace CONFIG_ECC_INIT_VIA_DDRC references 83xx: Add support for fsl_dma driver

 board/freescale/mpc8360emds/mpc8360emds.c |    4 +-
 board/freescale/mpc8360erdk/mpc8360erdk.c |    4 +-
 board/freescale/mpc837xemds/mpc837xemds.c |    4 +-
 board/freescale/mpc837xerdb/mpc837xerdb.c |    4 +-
 board/keymile/kmeter1/kmeter1.c           |    4 +-
 board/mpc8540eval/mpc8540eval.c           |   35 +------
 board/sbc8560/sbc8560.c                   |   33 +-----
 cpu/mpc83xx/cpu.c                         |   85 --------------
 cpu/mpc83xx/spd_sdram.c                   |   43 +------
 cpu/mpc85xx/cpu.c                         |   47 --------
 cpu/mpc85xx/cpu_init.c                    |    4 +-
 cpu/mpc85xx/ddr-gen1.c                    |   33 +-----
 cpu/mpc86xx/cpu.c                         |   55 ---------
 cpu/mpc86xx/cpu_init.c                    |    3 +
 drivers/dma/Makefile                      |    1 +
 drivers/dma/fsl_dma.c                     |  178 +++++++++++++++++++++++++++++
 include/asm-ppc/config.h                  |    8 ++
 include/asm-ppc/fsl_dma.h                 |   90 +++++++++++++++
 include/asm-ppc/immap_83xx.h              |   49 +-------
 include/configs/PM854.h                   |    1 +
 include/configs/PM856.h                   |    1 +
 include/mpc83xx.h                         |   16 ---
 22 files changed, 308 insertions(+), 394 deletions(-)
 create mode 100644 drivers/dma/fsl_dma.c