Skip to content

More Build System cleanups (v2)

[email protected] qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest19 patches 6 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/19fix XEN BuildMakefile.target+1 -13 replies
2/19fix sparc not solaris buildMakefile.target+1 -10 replies
3/19Remove duplicated definitionMakefile.target+0 -20 replies
4/19use block-nested-y for files inside block/Makefile+11 -90 replies
5/19use nwfpe-obj-y for consistenceMakefile.target+4 -30 replies
6/19Remove unused Makefile variableMakefile.target+1 -10 replies
7/19already defined several lines before in block-obj-yMakefile+1 -10 replies
8/19configure already knows what TARGET_BASE_ARCH we need, no need to put the logic in Makefile.targetMakefile.target configure+10 -200 replies
9/19TARGET_ARCH2 is already known at configure time and it is called target_cpu Remove re-construction in Makefile.targetMakefile.target configure+11 -310 replies
10/19chang ifdefs by obj-Makefile.target+93 -880 replies
11/19configure xen in a single placeconfigure+7 -103 replies
12/19configure kvm in a single placeconfigure+13 -280 replies
13/19configure kqemu in a single placeconfigure+5 -100 replies
14/19BASE_LDFLAGS is not used anywhere elseMakefile.target+0 -40 replies
15/19TARGET_ARCH == TARGET_BASE_ARCH in m68k and armMakefile.target+8 -90 replies
16/19Refactor a single rule to generate all qemu-* executablesMakefile.target+9 -130 replies
17/19qemu binary don't exist anymore. I guess not much people is compiling on alphaMakefile.target+0 -70 replies
18/19We can wrap OS_CFLAGS/OS_LDFLAGS in CFLAGS/LDFLAGS at configure timeMakefile Makefile.hw Makefile.target +1 more+8 -100 replies
19/19We can wrap ARCH_CFLAGS/ARCH_LDFLAGS in CFLAGS/LDFLAGS at configure timeMakefile Makefile.hw Makefile.target +1 more+2 -170 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [Qemu-devel] [PATCH 00/19] More Build System cleanups (v2)

From: Juan Quintela <[email protected]>

Hi

This series rebase my changes on top of today git. Also add more cleanups. Anthony, feel free to cherry pick any patches that you like, if you don't want all of them.

- The bigger stuff here is move to only one qemu compilation rule for both bsd-user/darwin-user/linux-user/softmmu (the only thing that really changed was ARLIBS

- Start moving CFLAGS/LDFLAGS setup to ./configure. Just removed OS_* and ARCH_*, planing how to move the other ones.

Comments? For yesterday series, only comment was that we needed more of it :)

Later, Juan "compiling for qemu ifdef removal prize"

v1:

More cleanups, 1st two are two compile fixes for my previous series (the XEN one already sent to the list.

Generate TARGET_BASE_ARCH and TARGET_CPU on configure, and then we don't complicate Makefile.target having to regerate it.

Switch all objects that depends of one traget to obj-$(TARGET_BASE_ARCH)-y variable, that way we would be able to share Makefiles at some point.

Once there, fix kvm, xen and kqemu to not being duplicated for each arch that support i.t

Juan Quintela (19):
fix XEN Build
fix sparc not solaris build
Remove duplicated definition
use block-nested-y for files inside block/
use nwfpe-obj-y for consistence
Remove unused Makefile variable
already defined several lines before in block-obj-y configure already knows what TARGET_BASE_ARCH we need, no need to put
the logic in Makefile.target
TARGET_ARCH2 is already known at configure time and it is called
target_cpu Remove re-construction in Makefile.target
chang ifdefs by obj-
configure xen in a single place
configure kvm in a single place
configure kqemu in a single place
BASE_LDFLAGS is not used anywhere else
TARGET_ARCH == TARGET_BASE_ARCH in m68k and arm
Refactor a single rule to generate all qemu-* executables qemu binary don't exist anymore. I guess not much people is
compiling on alpha
We can wrap OS_CFLAGS/OS_LDFLAGS in CFLAGS/LDFLAGS at configure time We can wrap ARCH_CFLAGS/ARCH_LDFLAGS in CFLAGS/LDFLAGS at configure
time

 Makefile        |   26 +++---
 Makefile.hw     |    3 -
 Makefile.target |  290 ++++++++++++++++++++++---------------------------------
 configure       |  101 ++++++++-----------
 4 files changed, 170 insertions(+), 250 deletions(-)