Skip to content

More Build System cleanups (v3)

[email protected] qemu-devel 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest26 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/26fix XEN BuildMakefile.target+1 -10 replies
2/26fix sparc not solaris buildMakefile.target+1 -10 replies
3/26Remove duplicated definitionMakefile.target+0 -20 replies
4/26use block-nested-y for files inside block/Makefile+11 -90 replies
5/26use nwfpe-obj-y for consistenceMakefile.target+4 -30 replies
6/26Remove unused Makefile variableMakefile.target+1 -10 replies
7/26already defined several lines before in block-obj-yMakefile+1 -10 replies
8/26configure already knows what TARGET_BASE_ARCH we need, no need to put the logic in Makefile.targetMakefile.target configure+10 -200 replies
9/26TARGET_ARCH2 is already known at configure time.Makefile.target configure+6 -260 replies
10/26change ifdefs by obj-$(TARGET_BASE_ARCH)Makefile.target+93 -880 replies
11/26configure xen in a single placeconfigure+7 -100 replies
12/26configure kvm in a single placeconfigure+12 -280 replies
13/26configure kqemu in a single placeconfigure+5 -100 replies
14/26BASE_LDFLAGS is not used anywhere elseMakefile.target+0 -40 replies
15/26TARGET_ARCH == TARGET_BASE_ARCH in m68k and armMakefile.target+8 -90 replies
16/26Refactor a single rule to generate all qemu-* executablesMakefile.target+9 -130 replies
17/26qemu binary don't exist anymore. I guess not much people is compiling on alphaMakefile.target+0 -70 replies
18/26We can wrap OS_CFLAGS/OS_LDFLAGS in CFLAGS/LDFLAGS at configure timeMakefile Makefile.hw Makefile.target +1 more+8 -100 replies
19/26We can wrap ARCH_CFLAGS/ARCH_LDFLAGS in CFLAGS/LDFLAGS at configure timeMakefile Makefile.hw Makefile.target +1 more+2 -170 replies
20/26generate ARCH name instead of coding itconfigure+21 -340 replies
21/26Refactor common code using a listconfigure+3 -480 replies
22/26Refactor targe_bigendian selection in another listconfigure+5 -140 replies
23/26print only once TARGET_ARCHconfigure+19 -180 replies
24/26Only setup TARGET_ARCH when it is different ofconfigure+1 -110 replies
25/26generate TARGET_ARCH for config.hconfigure+2 -180 replies
26/26generate TARGET_<arch name> for config.hconfigure+8 -160 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [Qemu-devel] [PATCH 00/26] More Build System cleanups (v3)

From: Juan Quintela <[email protected]>

Hi

Yet more cleanups. Apart from rebasing to today qemu, I have:

Re-factor ARCH/TARGET_ARCH code to avoid duplicated code.
That code is not finished yet, but you can get one idea of the way that I think should be cleaned.

Basically I am:
a- generating the config*.h variables from the config*.mak variables
(that is still done on configure, but will be done other place at some point).
b- use the pattern:
var=""
case $other_var in
.... lot of stuff ....
esac
if [ "$var" = "" ]; then
var=default_value
fi
.... use $var ....

Anthony, just feel free to stop on the 19 patch (that is the last one that I sent in the previous series).

As always, any comments, suggestions?

Later, Juan.

v2:

This series rebase my changes on top of today git. Also add more cleanups. Anthony, feel free to cherry pick any patches that you like, if you don't want all of them.

- The bigger stuff here is move to only one qemu compilation rule for both bsd-user/darwin-user/linux-user/softmmu (the only thing that really changed was ARLIBS

- Start moving CFLAGS/LDFLAGS setup to ./configure. Just removed OS_* and ARCH_*, planing how to move the other ones.

Comments? For yesterday series, only comment was that we needed more of it :)

Later, Juan "compiling for qemu ifdef removal prize"

v1:

More cleanups, 1st two are two compile fixes for my previous series (the XEN one already sent to the list.

Generate TARGET_BASE_ARCH and TARGET_CPU on configure, and then we don't complicate Makefile.target having to regerate it.

Switch all objects that depends of one traget to obj-$(TARGET_BASE_ARCH)-y variable, that way we would be able to share Makefiles at some point.

Once there, fix kvm, xen and kqemu to not being duplicated for each arch that support i.t

Juan Quintela (26):
fix XEN Build
fix sparc not solaris build
Remove duplicated definition
use block-nested-y for files inside block/
use nwfpe-obj-y for consistence
Remove unused Makefile variable
already defined several lines before in block-obj-y configure already knows what TARGET_BASE_ARCH we need, no need to put
the logic in Makefile.target
TARGET_ARCH2 is already known at configure time.
change ifdefs by obj-$(TARGET_BASE_ARCH)
configure xen in a single place
configure kvm in a single place
configure kqemu in a single place
BASE_LDFLAGS is not used anywhere else
TARGET_ARCH == TARGET_BASE_ARCH in m68k and arm
Refactor a single rule to generate all qemu-* executables qemu binary don't exist anymore. I guess not much people is
compiling on alpha
We can wrap OS_CFLAGS/OS_LDFLAGS in CFLAGS/LDFLAGS at configure time We can wrap ARCH_CFLAGS/ARCH_LDFLAGS in CFLAGS/LDFLAGS at configure
time
generate ARCH name instead of coding it
Refactor common code using a list
Refactor targe_bigendian selection in another list
print only once TARGET_ARCH
Only setup TARGET_ARCH when it is different of
generate TARGET_ARCH for config.h
generate TARGET_<arch name> for config.h

 Makefile        |   26 +++---
 Makefile.hw     |    3 -
 Makefile.target |  282 ++++++++++++++++++++++---------------------------------
 configure       |  260 ++++++++++++++-------------------------------------
 4 files changed, 195 insertions(+), 376 deletions(-)