Skip to content

RFC Generate config_h from config.mak

[email protected] qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest6 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6simplify TARGET_BASE_ARCH generationMakefile.target configure+16 -210 replies
2/6simplify TARGET_ARCH2 generationMakefile.target configure+2 -120 replies
3/6simplify TARGET_ABI_DIR generationMakefile.target configure+9 -70 replies
4/6rename s/config_mak/config_host_mak/ and s/config_h/config_host_h/configure+153 -1550 replies
5/6Refactor config_softfloat selection in another listconfigure+7 -200 replies
6/6Generate $target_dir/config.h from $target_dir/config.makcreate_config+55 -01 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [Qemu-devel] [RFC PATCH 0/6] Generate config_h from config.mak

From: Juan Quintela <[email protected]>

Hi

This patches apply on top of my previous series.
I generate $target_dir/config.h from $target_dir/config.mak

ToDo:
- generate config-host.h from config-host.mak
- USE_NPTL -> can I rename it to CONFIG_USE_NPTL?
- TARGET_ABI_MIPS{O32,N32,N64}. Rest of architectures use names like:
TARGET_ABI_MIPSN32 -> TARGET_MIPSN32
TARGET_ABI_MIPSN64 -> TARGET_MIPSN64
not sure how to do the TARGET_ABI_MIPSO32
This one is only to have coherent options names, rest of architectures have enough with TARGET_ARCH, TARGET_ARCH2, TARGET_BASE_ARCH, TARGET_$ARCH_NAME TARGET_$BASE_ARCH_NAME

- TARGET_ARCH2 -> can we rename it to TARGET_SUBARCH or something more descriptive
- do we want TARGET_BASE_ARCH defined for .h files?
- move all CPPFLAGS/CFLAGS/LDFLAGS/LIBS to configure and export only this 4 variables (both for config.mak and config-host.mak). I don't think that this only 4 vars will be enough, but I am sure that we can export less than we have now.
- remove rest of intelligence (also known as ifs) possible from Makefile* and moved it back to ./configure
- once previous steps are done, be able to configure the devices using this (or similar mechanism)

Comments?

Later, Juan.

Juan Quintela (6):
simplify TARGET_BASE_ARCH generation
simplify TARGET_ARCH2 generation
simplify TARGET_ABI_DIR generation
rename s/config_mak/config_host_mak/ and s/config_h/config_host_h/ Refactor config_softfloat selection in another list Generate $target_dir/config.h from $target_dir/config.mak

 Makefile.target |   11 --
 configure       |  391 ++++++++++++++++++++++++++-----------------------------
 create_config   |   55 ++++++++
 3 files changed, 242 insertions(+), 215 deletions(-)
 create mode 100755 create_config