Skip to content

Generate a proper LIBS variable

[email protected] qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest37 patches 21 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/37change HOST_SOLARIS to CONFIG_SOLARIS{_VERSION}configure cpu-exec.c dyngen-exec.h +7 more+28 -230 replies
2/37Remove SP_CFLAGS and SP_LDFLAGSconfigure+22 -130 replies
3/37target_arch2 is redefined unconditionally laterconfigure+0 -30 replies
4/37remove CONFIG_ from VNC_TLS_{LIBS, FLAGS}Makefile Makefile.target configure+5 -50 replies
5/37use same algorithm for testing andconfigure+7 -10 replies
6/37remove CONFIG_ from VNC_SASL_{LIBS, FLAGS}Makefile.target configure+4 -40 replies
7/37remove CONFIG_ from BLUEZ_{LIBS,FLAGS}Makefile Makefile.target configure+4 -40 replies
8/37make fmod also use FMOD_{LIBS,CFLAGS}Makefile Makefile.target configure+4 -40 replies
9/37make oss use OSS_LIBSMakefile.target configure+2 -20 replies
10/37move printing of config-host.mak variables to end of generationconfigure+27 -250 replies
11/37more specific config.mak can overwrote more general config.makMakefile.hw+1 -10 replies
12/37generate CPPFLAGS and LIBS on ./configureMakefile Makefile.target configure+12 -41 reply
13/37fold PTHREADLIBS and CLOCKLIBS on generic LIBSMakefile Makefile.target configure+2 -120 replies
14/37CONFIG_SOLARIS always want -lsockt -lnsl -lresolvMakefile Makefile.target configure+1 -50 replies
15/37Add -static in configure if neededMakefile Makefile.target configure+1 -140 replies
16/37generate CONFIG_WIN32 libraries in configureMakefile Makefile.target configure+1 -70 replies
17/37fold VDE_LIBS on generic LIBSMakefile Makefile.target configure+2 -40 replies
18/37fold CURL_LIBS on generic LIBSMakefile Makefile.target configure+2 -40 replies
19/37fold BRLAPI_LIBS on generic LIBSMakefile Makefile.target configure+2 -60 replies
20/37fold CURSES_LIBS on generic LIBSMakefile.target configure+3 -30 replies
21/37fold XEN_LIBS on generic LIBSMakefile.target configure+1 -40 replies
22/37fold BLUEZ_LIBS on generic LIBSMakefile.target configure+2 -60 replies
23/37fold VNC_TLS_LIBS on generic LIBSMakefile.target configure+1 -20 replies
24/37fold VNC_SASL_LIBS on generic LIBSMakefile.target configure+1 -20 replies
25/37Rename HAVE_FDT to CONFIG_FDT and define it also in MakefileMakefile.target configure hw/petalogix_s3adsp1800_mmu.c +3 more+10 -90 replies
26/37Refactor code to remove one #ifdef CONFIG_FDThw/petalogix_s3adsp1800_mmu.c+2 -40 replies
27/37fold FDT_LIBS on generic LIBSMakefile.target configure+1 -70 replies
28/37fold NEEDS_LIBSUNMATH on generic variablesMakefile.target configure+3 -70 replies
29/37fold FMOD_LIBS on generic LIBSMakefile.target configure+1 -40 replies
30/37fold OSS_LIBS on generic LIBSMakefile.target configure+1 -40 replies
31/37fold ALSA libs on generic LIBSMakefile.target configure+2 -30 replies
32/37fold DSOUND libs on generic LIBSMakefile.target configure+2 -30 replies
33/37fold Pulse Audio libs on generic LIBSMakefile.target configure+2 -30 replies
34/37fold ESD libs on generic LIBSMakefile.target configure+2 -30 replies
35/37fold COCOA_LIBS on generic LIBSMakefile.target configure+4 -70 replies
36/37fold SDL_LIBS on generic LIBSMakefile.target configure+5 -80 replies
37/37remove rt variable, we can assign directly LIBSconfigure+0 -50 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [Qemu-devel] [PATCH 00/37] Generate a proper LIBS variable

From: Juan Quintela <[email protected]>

Hi

Instead of having *_LIBS variables, generate a proper LIBS variable in configure and use it in Makefiles.

- Remove lots of other ifdef in Makefiles.
- s/HOST_SOLARIS/CONFIG_SOLARIS/ for coherence
- s/HAVE_FDT/CONFIG_FDT/
- Patches are very small/trivials to make easy bisect problems in other architectures/SSOOs

ToDo:
- Make the same treatment for CFLAGS, CPPFLAGS and LDFLAGS.
- Once done that, generate the config-host.h from config-host.mak (as done in the target directories).

I have compiled it in linux x86_64 and crosscompiled to windows. Testers wanted for:

- Mac OS X
- Solaris (specially sparc)
- BSD's

It should just work (famous last words)

Thanks in advance, Juan.

Juan Quintela (37):
change HOST_SOLARIS to CONFIG_SOLARIS{_VERSION} Remove SP_CFLAGS and SP_LDFLAGS
target_arch2 is redefined unconditionally later remove CONFIG_ from VNC_TLS_{LIBS,FLAGS}
use same algorithm for testing and
remove CONFIG_ from VNC_SASL_{LIBS,FLAGS}
remove CONFIG_ from BLUEZ_{LIBS,FLAGS}
make fmod also use FMOD_{LIBS,CFLAGS}
make oss use OSS_LIBS
move printing of config-host.mak variables to end of generation more specific config.mak can overwrote more general config.mak generate CPPFLAGS and LIBS on ./configure
fold PTHREADLIBS and CLOCKLIBS on generic LIBS CONFIG_SOLARIS always want -lsockt -lnsl -lresolv
Add -static in configure if needed
generate CONFIG_WIN32 libraries in configure
fold VDE_LIBS on generic LIBS
fold CURL_LIBS on generic LIBS
fold BRLAPI_LIBS on generic LIBS
fold CURSES_LIBS on generic LIBS
fold XEN_LIBS on generic LIBS
fold BLUEZ_LIBS on generic LIBS
fold VNC_TLS_LIBS on generic LIBS
fold VNC_SASL_LIBS on generic LIBS
Rename HAVE_FDT to CONFIG_FDT and define it also in Makefile Refactor code to remove one #ifdef CONFIG_FDT
fold FDT_LIBS on generic LIBS
fold NEEDS_LIBSUNMATH on generic variables
fold FMOD_LIBS on generic LIBS
fold OSS_LIBS on generic LIBS
fold ALSA libs on generic LIBS
fold DSOUND libs on generic LIBS
fold Pulse Audio libs on generic LIBS
fold ESD libs on generic LIBS
fold COCOA_LIBS on generic LIBS
fold SDL_LIBS on generic LIBS
remove rt variable, we can assign directly LIBS

 Makefile                      |   30 +------
 Makefile.hw                   |    2 +-
 Makefile.target               |   80 +------------------
 configure                     |  175 ++++++++++++++++++++++++----------------
 cpu-exec.c                    |   10 +-
 dyngen-exec.h                 |    2 +-
 fpu/softfloat-native.c        |   13 ++-
 fpu/softfloat-native.h        |    9 +-
 fpu/softfloat.h               |    2 +-
 hw/petalogix_s3adsp1800_mmu.c |    8 +-
 hw/ppc440_bamboo.c            |    2 +-
 hw/ppce500_mpc8544ds.c        |    4 +-
 kqemu.c                       |    2 +-
 osdep.c                       |    6 +-
 target-mips/cpu.h             |    2 +-
 target-ppc/kvm_ppc.c          |    2 +-
 tcg/sparc/tcg-target.h        |    2 +-
 17 files changed, 148 insertions(+), 203 deletions(-)