Skip to content

optionrom build fixes

[email protected] qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5move cc-option definition to rules.makMakefile.target rules.mak+6 -60 replies
2/5Use quiet-command for building optionrompc-bios/optionrom/Makefile+7 -90 replies
3/5use cc-option for optionrompc-bios/optionrom/Makefile+1 -210 replies
4/5multiboot.bin is a generated file.gitignore+1 -00 replies
5/5Don't build option roms on Mac OS Xconfigure+3 -10 replies

Reviews trailers per patch

None of the 5 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchAlexander Graf
SeriesA-b
1/5
2/5
3/5
4/5
5/5

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [Qemu-devel] [PATCH 0/5] optionrom build fixes

From: Juan Quintela <[email protected]>

Hi

This series of patches get optionrom to use rules.mak and use the normal qemu build system. As it used its own variant of cc-option, move cc-option definition to rules.mak and remove the own implementation in optionrom.

Anthony, this one includes my two previous patches to this zone:
- put pc-bios/optionrom/multiboot.bin into .gitignore
- Don't build it in mac os X

cc'd alexander graf, that was the original author.

Later, Juan.

Juan Quintela (5):
move cc-option definition to rules.mak
Use quiet-command for building optionrom
use cc-option for optionrom
multiboot.bin is a generated file
Don't build option roms on Mac OS X

 .gitignore                 |    1 +
 Makefile.target            |    6 ------
 configure                  |    4 +++-
 pc-bios/optionrom/Makefile |   36 +++++++-----------------------------
 rules.mak                  |    6 ++++++
 5 files changed, 17 insertions(+), 36 deletions(-)