Make pcspk like rest of audio cards
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest3 patches 0 repliesNew
- v13 patches 1 replySuperseded
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | Bring audio cards structs to C99 initializersvl.c | +37 | 0 replies | |
| 2/3 | What cards to compile is a per target thingconfigure | +5 | 0 replies | |
| 3/3 | Make pc speaker be configured the same way that the rest of the cardsMakefile.target configure vl.c | +11 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.
Cover letter [Qemu-devel] [PATCH v2 0/3] Make pcspk like rest of audio cards
v2
We use c99 initializers in malc style, open and closed parents in the same line, and = signs aligned.
v1:
This patch series add c99 initializers to sound cards in vl.c. Sound card support depends of target, move CONFIG_FOO generation there. Once here, I wanted to disable CONFIG_PCSPK, but found a problem.
pcskpr is registered as a port on mips_jazz.c and pc.c, and then as an audio card.
Options are:
- let things as they are (if you get a pc or mips_jazz, you get a pc speaker port and a pcspk audio card.
- be able to remove pc speaker audio support, but let the speaker port as it is now
- make pcspk_init() an empty function in hw.h depending of CONFIG_PCSPK value.
Any thoughts?
Later, Juan.
Juan Quintela (3):
Bring audio cards structs to C99 initializers
What cards to compile is a per target thing
Make pc speaker be configured the same way that the rest of the cards
Makefile.target | 5 ++- configure | 16 +++++++-- vl.c | 91 +++++++++++++++++++++++-------------------------------- 3 files changed, 53 insertions(+), 59 deletions(-)