Skip to content

Make --enable-foo a requirement

Juan Quintela qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest20 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/20Make vnc configure options less verbose.configure+0 -80 replies
2/20Use the same structure for list of libs in curses and pthreadconfigure+10 -80 replies
3/20Add feature configure helpconfigure+11 -00 replies
4/20Add error message for feature not foundconfigure+10 -00 replies
5/20Add brlapi to new feature convencionconfigure+10 -30 replies
6/20Add vde to new feature convencionconfigure+11 -30 replies
7/20Add vnc_tls to new feature convencionconfigure+16 -90 replies
8/20Add vnc_sasl to new feature convencionconfigure+16 -90 replies
9/20Add curses to new feature convencionconfigure+15 -40 replies
10/20Add curl to new feature convencionconfigure+10 -30 replies
11/20Add pthread to new feature convencionconfigure+15 -40 replies
12/20Add nptl to new feature convencionconfigure+18 -72 replies
13/20Add bluez to new feature convencionconfigure+10 -50 replies
14/20Add build_docs to new feature conventionconfigure+13 -30 replies
15/20Rename build_docs to docsconfigure+10 -100 replies
16/20Add sdl to new feature conventionconfigure+10 -30 replies
17/20Add fdt to new feature conventionconfigure+13 -30 replies
18/20Add xen to new feature conventionconfigure+10 -30 replies
19/20Add kvm to new feature conventionconfigure+18 -130 replies
20/20Add sparse to new feature conventionconfigure+14 -50 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [Qemu-devel] [PATCH 00/20] Make --enable-foo a requirement

Hi

--enable-foo in current qemu just means to enable foo if it founds it, otherwise just not enable it silently. This patches changed everything to use the convention:

* foo="no", feature will only be used if --enable-foo arg is given
* foo="", feature will be searched for, and if found, will be used
* foo="yes", this value vill only be set by --enable-foo flag.
feature will searched for, if not found, configure exits with error

It is important for distributions. Otherwise, if something is not installed, things don't fail to compile, just are disabled.

Once there, add --enable-foo for all things that already have --disable-foo and make sense. There are still a few bits that donot' have both --enable-foo/--disable-foo, but they are the minimal things.

kvm: the extra error message is only given if you do a --enable-kvm, by default, if kvm is not found, it just fails, as everything else.

Questions:
- sdl: anyone really uses sdl + static? I am not sure that they compile correctly, and they are just complicated.
- Do we want to sort things on the file? I.e. libraries detection toguether, features detection together, .... Just new they are a completely mess, completely unsorted as far as I can see.

Later, Juan.

Juan Quintela (20):
Make vnc configure options less verbose.
Use the same structure for list of libs in curses and pthread Add feature configure help
Add error message for feature not found
Add brlapi to new feature convencion
Add vde to new feature convencion
Add vnc_tls to new feature convencion
Add vnc_sasl to new feature convencion
Add curses to new feature convencion
Add curl to new feature convencion
Add pthread to new feature convencion
Add nptl to new feature convencion
Add bluez to new feature convencion
Add build_docs to new feature convention
Rename build_docs to docs
Add sdl to new feature convention
Add fdt to new feature convention
Add xen to new feature convention
Add kvm to new feature convention
Add sparse to new feature convention

 configure |  319 +++++++++++++++++++++++++++++++++++++++++++-----------------
 1 files changed, 228 insertions(+), 91 deletions(-)