Skip to content

SaveVM: Remove ram support for v1 and v2

Juan Quintela qemu-devel 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2ram: remove support for loading v1vl.c+0 -420 replies
2/2ram: Remove SaveVM Version 2 supportvl.c+1 -930 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [Qemu-devel] [PATCH 0/2] SaveVM: Remove ram support for v1 and v2

Hi

SaveVM don't work for v2 since at least April.

Quoted 1 line

From commit message of removal of v2:

It don't work. It fails in this check

        if (qemu_get_be32(f) != last_ram_offset)

With 512MB of ram, values were for me:

	v = 20c00000 last_ram_offset = 20840000

Last time that some code changed that was this one.

commit 94a6b54fd6d2d3321066cb4db7abeeb417af9365 Implement dynamic guest ram allocation. (I.e. it has been broken since at least April)

Going back to the previous commit, ram load correctly, but vga screen gets corrupted and ide don't load correctly. At this point I decide that removing support is the only viable thing.

The last user of the ram_compress_* were RAM_SAVE_FLAG_FULL flag, but that flag was never ever been stored in an image. Mark the flag obsolete and remove the functions.

Later, Juan.

Juan Quintela (2):
ram: remove support for loading v1
ram: Remove SaveVM Version 2 support

 vl.c |  136 +-----------------------------------------------------------------
 1 files changed, 1 insertions(+), 135 deletions(-)