Skip to content

VMState: port several pc devices to vmstate

Juan Quintela qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest26 patches 35 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/26ram: remove support for loading v1vl.c+0 -420 replies
2/26ram: Remove SaveVM Version 2 supportvl.c+1 -930 replies
3/26Remove SaveVM v2 supportsavevm.c+4 -4311 replies
4/26timers: remove useless checkvl.c+0 -60 replies
5/26Unexport ticks_per_sec variable. Create get_ticks_per_sec() functionaudio/audio.c audio/noaudio.c audio/wavaudio.c +41 more+130 -11324 replies
6/26timers: Createt TimersState and put all timers state therevl.c+39 -310 replies
7/26timers: move them to VMStatevl.c+12 -220 replies
8/26vmstate: add sensible arguments to vmstate_unregister()hw/hw.h savevm.c+10 -30 replies
9/26vmstate: rename run_after_load() -> post_load()hw/acpi.c hw/hw.h hw/piix_pci.c +3 more+12 -110 replies
10/26vmstate: Add pre_load() hookhw/hw.h savevm.c+6 -00 replies
11/26vmstate: Add pre/post_save() hookshw/hw.h savevm.c+8 -00 replies
12/26vmstate: port cpu_comonexec.c+25 -140 replies
13/26vmstate: port fw_cfg devicehw/fw_cfg.c+12 -210 replies
14/26vmstate: port i8259 devicehw/i8259.c+26 -480 replies
15/26vmstate: add support for uint8_t equalhw/hw.h savevm.c+24 -00 replies
16/26vmstate: port fdc devicehw/fdc.c+62 -920 replies
17/26vmstate: add support for arrays of uint16_thw/hw.h+6 -00 replies
18/26vmstate: port dma devicehw/dma.c+34 -510 replies
19/26vmstate: port vmmouse devicehw/vmmouse.c+20 -280 replies
20/26vmstate: port pckbd devicehw/pckbd.c+16 -250 replies
21/26vmstate: add uint64 array supporthw/hw.h+6 -00 replies
22/26vmstate: port ioapic devicehw/ioapic.c+12 -270 replies
23/26hpet: it is imposible that qemu_timer field is NULL at this pointhw/hpet.c+2 -60 replies
24/26vmstate: port hpet devicehw/hpet.c+38 -350 replies
25/26vmstate: port serial devicehw/serial.c+37 -360 replies
26/26vmstate: port cirrus_vga devicehw/cirrus_vga.c hw/hw.h+63 -980 replies

Reviews trailers per patch

1 of 26 patches has a Reviewed-by or Acked-by.

PatchJuan Quintela
1/26
2/26
3/26
4/26
5/26A-b
6/26
7/26
8/26
9/26
10/26
11/26
12/26
13/26
14/26
15/26
16/26
17/26
18/26
19/26
20/26
21/26
22/26
23/26
24/26
25/26
26/26

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [Qemu-devel] [PATCH 00/26] VMState: port several pc devices to vmstate

This series:
- remove support for RAM v1 and v2 (I created an image with latest qemu before switching to RAM v3 and try to load with current qemu). It don't work (physical_ram_size value has changed), and it don't work since at least April). I went to that commit, and after fixing RAM, ide didn't load, and vga screen got corrupted).
- Remove SaveVM v2 support. This support is older than then switch to RAMv3, if you can't load RAM -> you can't load any image in any meaningful way.
- port several devices to vmstate.
- To port timers, I have to move ticks_per_sec in an accessor function patch is quite big, but it is trivial.

Devices left to have my minimal pc using only vmstate:
- cpu (dragons here, this is huge and has all special cases that you can think)
- ide: medium size, identiyfy_data that can/can't be there is the more complicated thing.
- virtio-net: more dragons here, we need a nice way to split virtio & virtio-pci just now their relation is too incestuous.
- mc146818rtc: See my other RFC mail about changing how rtc-td-hack is handled during save/load.

I guess that I missed some device, but this is one start.

Later, Juan.

Juan Quintela (26):
ram: remove support for loading v1
ram: Remove SaveVM Version 2 support
Remove SaveVM v2 support
timers: remove useless check
Unexport ticks_per_sec variable. Create get_ticks_per_sec() function
timers: Createt TimersState and put all timers state there
timers: move them to VMState
vmstate: add sensible arguments to vmstate_unregister()
vmstate: rename run_after_load() -> post_load()
vmstate: Add pre_load() hook
vmstate: Add pre/post_save() hooks
vmstate: port cpu_comon
vmstate: port fw_cfg device
vmstate: port i8259 device
vmstate: add support for uint8_t equal
vmstate: port fdc device
vmstate: add support for arrays of uint16_t
vmstate: port dma device
vmstate: port vmmouse device
vmstate: port pckbd device
vmstate: add uint64 array support
vmstate: port ioapic device
hpet: it is imposible that qemu_timer field is NULL at this point
vmstate: port hpet device
vmstate: port serial device
vmstate: port cirrus_vga device

 audio/audio.c        |    2 +-
 audio/noaudio.c      |    4 +-
 audio/wavaudio.c     |    2 +-
 exec.c               |   39 ++++++---
 hw/acpi.c            |   13 ++--
 hw/adlib.c           |    2 +-
 hw/baum.c            |    3 +-
 hw/bt-hci-csr.c      |    4 +-
 hw/bt-hci.c          |    4 +-
 hw/cirrus_vga.c      |  152 ++++++++++++---------------------
 hw/cuda.c            |   14 ++--
 hw/dma.c             |   85 +++++++-----------
 hw/dp8393x.c         |    2 +-
 hw/fdc.c             |  156 +++++++++++++--------------------
 hw/fw_cfg.c          |   33 +++-----
 hw/hpet.c            |   77 ++++++++--------
 hw/hw.h              |   32 +++++++-
 hw/i8254.c           |   14 ++-
 hw/i8259.c           |   77 ++++++-----------
 hw/ide/core.c        |    2 +-
 hw/ioapic.c          |   39 +++------
 hw/mc146818rtc.c     |   16 ++--
 hw/mips_timer.c      |   10 +-
 hw/omap1.c           |   16 ++--
 hw/omap2.c           |    4 +-
 hw/pckbd.c           |   41 ++++------
 hw/pcnet.c           |    2 +-
 hw/pflash_cfi02.c    |    4 +-
 hw/piix_pci.c        |    4 +-
 hw/pl031.c           |    6 +-
 hw/ppc.c             |   18 ++--
 hw/ppc405_uc.c       |    4 +-
 hw/pxa2xx_timer.c    |   14 ++--
 hw/rc4030.c          |    3 +-
 hw/rtl8139.c         |    5 +-
 hw/sb16.c            |    4 +-
 hw/serial.c          |   79 +++++++++--------
 hw/slavio_intctl.c   |    4 +-
 hw/spitz.c           |    3 +-
 hw/stellaris.c       |    2 +-
 hw/tcx.c             |    4 +-
 hw/tsc2005.c         |    2 +-
 hw/tsc210x.c         |    2 +-
 hw/tusb6010.c        |    4 +-
 hw/usb-musb.c        |    2 +-
 hw/usb-ohci.c        |   10 +-
 hw/usb-uhci.c        |    2 +-
 hw/vga.c             |    6 +-
 hw/vmmouse.c         |   48 ++++------
 hw/wdt_i6300esb.c    |    2 +-
 hw/wdt_ib700.c       |    2 +-
 monitor.c            |    6 +-
 net.c                |    2 +-
 qemu-timer.h         |    2 +-
 savevm.c             |   94 ++++++++++----------
 target-ppc/kvm_ppc.c |    2 +-
 vl.c                 |  235 +++++++++++---------------------------------------
 57 files changed, 590 insertions(+), 830 deletions(-)