VMState: port all i2c devices
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest20 patches 4 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/20 | qdev: Add support for uint8_thw/ hw/ | +38 | 0 replies | |
| 2/20 | i2c: addresses are load/save as uint8_t values, change types to reflect thishw/ hw/ hw/ +3 more | +35 | 0 replies | |
| 3/20 | vmstate: port i2c_bus devicehw/ | +19 | 0 replies | |
| 4/20 | vmstate: port i2c_slave devicehw/ | +26 | 0 replies | |
| 5/20 | vmstate: add uint8 arrayhw/ | +6 | 0 replies | |
| 6/20 | vmstate: create VMSTATE_I2C_SLAVEhw/ hw/ | +12 | 0 replies | |
| 7/20 | vmstate: port wm8750 devicehw/ | +45 | 0 replies | |
| 8/20 | vmstate: port max7310 devicehw/ | +18 | 0 replies | |
| 9/20 | vmstate: create VMSTATE_STRUCT_POINTERhw/ | +9 | 0 replies | |
| 10/20 | vmstate: port pxa2xx_i2c devicehw/ | +26 | 0 replies | |
| 11/20 | vmstate: port ssd0303 devicehw/ | +22 | 0 replies | |
| 12/20 | vmstate: create VMSTATE_INT16_ARRAYhw/ | +6 | 0 replies | |
| 13/20 | tmp105: change len and alorm to uint8_thw/ | +2 | 0 replies | |
| 14/20 | vmstate: port wmp105 devicehw/ | +25 | 0 replies | |
| 15/20 | twl92230: change pwrbtn_state to uint8_thw/ | +1 | 0 replies | |
| 16/20 | vmstate: port twl92230 devicehw/ | +88 | 0 replies | |
| 17/20 | vmstate: add support for arrays of pointershw/ savevm.c | +18 | 0 replies | |
| 18/20 | lm832x: make fields to have the same types that they are saved/loadedhw/ | +22 | 0 replies | |
| 19/20 | vmstate: port lm832x devicehw/ | +37 | 0 replies | |
| 20/20 | vmstate: remove i2c_slave_load/savehw/ hw/ | +0 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [Qemu-devel] [PATCH 00/20] VMState: port all i2c devices
Hi
This patch is on top of my previous series:
[PATCH 00/26] VMState: port several pc devices to vmstate
This ports all i2c_devices to vmstate. Big changes:
- i2c->address now are uint8_t, my review of all uses is that they are always used as uint8_t (and that is the type that is passed on the value). If you know i2c, please check. Change 0002 looks big, but it is because as I was auditing the paths, I changed the types of the functios to reflect that they use uint8_t. Real part of the patch is changing the struct definitions.
- qdev: there was not support for uint8_t (the i2c addresses) in qdev, now it is I missed this change in my 1st pass (on mips_malta)
- qdev_prop_set_uint32(eeprom, "address", 0x50 + i);
+ qdev_prop_set_uint8(eeprom, "address", 0x50 + i);
And qdev complained during compilation. qdev++
- I had to fix lots of places where values of one type were sent with a different type. qemu_put_byte/qemu_put_be16/qemu_put_be32 should be just baned. Yesterday.
- tmp105: We have a winner, the 1st user of post_save(). Can anyone explain me what we need to do _anything_ after saving
s->faults = tmp105_faultq[(s->config >> 3) & 3]; /* F */
I can't see why saving have to change faults, and no, I don't understand what that line does.
- twl922230: here we go.
It pass all the fields of a struct tm (they are ints) as uint16_t. All solutions are bad (tm):
* marshalling the struct tm in a struct tm_16bits fields, and use normal vmstate
* up version and declare all previous versions baned. No forward migration for you.
* Do the hack that I did, new type:
vmstate_hack_int32_as_uint16
local to that function, and be done with it. It is a big hack, but the function were already abusing the format.
- lm832x: I got an unused command (0xff) to be send as an error. it was using an int, -1 means an error, and a small number meaned a command. As the numbers of commands is very limited, I think this is the best solution. Notice that we were doing this already when we saved/loaded the value. Name the constant instead of -1 to make things easier.
- vmstate arrays shortened the save/load code for this series _a lot_.
Comments? Test and reports from arm users are welcome (the only use of i2c in a pc is for smbus-eeprom, and it is a _very_ limited use).
Later, Juan.
Juan Quintela (20):
qdev: Add support for uint8_t
i2c: addresses are load/save as uint8_t values, change types to
reflect this
vmstate: port i2c_bus device
vmstate: port i2c_slave device
vmstate: add uint8 array
vmstate: create VMSTATE_I2C_SLAVE
vmstate: port wm8750 device
vmstate: port max7310 device
vmstate: create VMSTATE_STRUCT_POINTER
vmstate: port pxa2xx_i2c device
vmstate: port ssd0303 device
vmstate: create VMSTATE_INT16_ARRAY
tmp105: change len and alorm to uint8_t
vmstate: port wmp105 device
twl92230: change pwrbtn_state to uint8_t
vmstate: port twl92230 device
vmstate: add support for arrays of pointers
lm832x: make fields to have the same types that they are saved/loaded
vmstate: port lm832x device
vmstate: remove i2c_slave_load/save
hw/hw.h | 47 ++++++++++++ hw/i2c.c | 64 ++++++++++------ hw/i2c.h | 10 +-- hw/lm832x.c | 148 +++++++++++++++---------------------- hw/max7310.c | 51 +++++-------- hw/mips_malta.c | 2 +- hw/pc.c | 2 +- hw/pxa2xx.c | 54 +++++++------- hw/qdev-properties.c | 33 ++++++++ hw/qdev.h | 5 + hw/smbus.c | 18 ++-- hw/smbus.h | 18 ++-- hw/ssd0303.c | 65 ++++++----------- hw/tmp105.c | 60 +++++++-------- hw/twl92230.c | 200 ++++++++++++++++++++++---------------------------- hw/wm8750.c | 120 +++++++++++------------------- savevm.c | 3 + 17 files changed, 438 insertions(+), 462 deletions(-)