Skip to content

PCI IDE cleanup

Juan Quintela qemu-devel 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest12 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/12ide: change cast to DO_UPCASThw/ide/pci.c+2 -20 replies
2/12ide: Remove cast in pci_register_barhw/ide/pci.c+6 -120 replies
3/12ide: Remove duplicated definitionshw/ide/internal.h+0 -60 replies
4/12ide: remove uselsess casts from void *hw/ide/microdrive.c hw/ide/mmio.c+13 -130 replies
5/12ide: create ide/pci.h for common ide pci definitionshw/ide/pci.c hw/ide/pci.h+19 -130 replies
6/12ide: export needed ide-pci functions for splithw/ide/pci.c hw/ide/pci.h+20 -100 replies
7/12ide: split cmd646 and piix from pci.cMakefile.target hw/ide/cmd646.c hw/ide/pci.c +1 more+482 -3410 replies
8/12ide: PCIIDEState type field is not needed anymorehw/ide/cmd646.c hw/ide/pci.h hw/ide/piix.c+11 -300 replies
9/12ide: 'secondary' field is only used by cmd646hw/ide/pci.h+1 -10 replies
10/12ide: cmd646 we can get the pci device with container_ofhw/ide/cmd646.c+11 -60 replies
11/12ide: cmd646 ->unit has just the value that we wanthw/ide/cmd646.c+2 -20 replies
12/12ide: BMDMAState don't need a pci_dev field anymorehw/ide/cmd646.c hw/ide/internal.h hw/ide/piix.c+0 -30 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [Qemu-devel] [PATCH 00/12] PCI IDE cleanup

This patch cleans ide/pci.c:
- useless casts
- split piix and cmd646 from pci.c, this allows remove some code
- clean cmd646 to allow th eremoval of pci_dev from BMDMAState.

Later, Juan.

Juan Quintela (12):
ide: change cast to DO_UPCAST
ide: Remove cast in pci_register_bar
ide: Remove duplicated definitions
ide: remove uselsess casts from void *
ide: create ide/pci.h for common ide pci definitions
ide: export needed ide-pci functions for split
ide: split cmd646 and piix from pci.c
ide: PCIIDEState type field is not needed anymore
ide: 'secondary' field is only used by cmd646
ide: cmd646 we can get the pci device with container_of
ide: cmd646 ->unit has just the value that we want
ide: BMDMAState don't need a pci_dev field anymore

 Makefile.target     |    7 +-
 hw/ide/cmd646.c     |  272 ++++++++++++++++++++++++++++++++++++
 hw/ide/internal.h   |    7 -
 hw/ide/microdrive.c |   18 ++--
 hw/ide/mmio.c       |    8 +-
 hw/ide/pci.c        |  378 ++-------------------------------------------------
 hw/ide/pci.h        |   23 +++
 hw/ide/piix.c       |  195 ++++++++++++++++++++++++++
 8 files changed, 518 insertions(+), 390 deletions(-)
 create mode 100644 hw/ide/cmd646.c
 create mode 100644 hw/ide/pci.h
 create mode 100644 hw/ide/piix.c