Skip to content

vmstate cleanups and fixes

Juan Quintela qemu-devel 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest12 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/12vmstate: Avoid seekingsavevm.c+17 -30 replies
2/12vmstate: Fix info field of VMSTATE_MACADDRhw/hw.h+1 -10 replies
3/12vmstate: fix missing ARRAY_OF_POINTERS support on save statesavevm.c+3 -00 replies
4/12vmstate: Add support for VBUFFERShw/hw.h savevm.c+34 -60 replies
5/12vmstate: Introduce VMSTATE_STRUCT_TESThw/hw.h+11 -70 replies
6/12vmstate: Introduce VMSTATE_STRUCT_POINTER_TESThw/hw.h+10 -60 replies
7/12vmstate: Introduce UINT16_TEST supporthw/hw.h+3 -00 replies
8/12vmstate: remove usused VMSTATE_STRUCT_ARRAY_SIZE_UINT8hw/hw.h+0 -100 replies
9/12vmstate: Add support for multiplying size for a constanthw/hw.h savevm.c+19 -00 replies
10/12pci: vmstate_register() already assign consecutive numbers starting at 0hw/pci.c+1 -30 replies
11/12qdev: enable vmstate_unregister() supporthw/qdev.c+0 -20 replies
12/12savevm: Port to qdev.vmsd all devices that have qdevhw/ac97.c hw/cirrus_vga.c hw/cs4231a.c +23 more+60 -360 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [Qemu-devel] [PATCH 00/12] vmstate cleanups and fixes

The new features are going to be used in next series (virtio port to vmstate). I just sent it because the cleanups were needed for other people. This patch is on top of my audio vmstate changes series (but it should be independent).

- fseek + migration has stopped working, just read to a local buffer (Jan).
- macaddr: brown paper bug (Jan fixed it)
- We add support for test function in more types.
- qdev: fix vmstate_unregister call now that it has the right type.
- port all devices that don't need changes to qdev.vmsd (patch is largish, but it is very easy).
- multiply by a constant: this is needed for unsafe buffers, where we have the number of elements, not the full size of the buffer.

You can get it at:

http://repo.or.cz/w/qemu/quintela.git/shortlog/refs/heads/vmstate/cleanup

Later, Juan.

Jan Kiszka (1):
vmstate: Fix info field of VMSTATE_MACADDR

Juan Quintela (11):
vmstate: Avoid seeking
vmstate: fix missing ARRAY_OF_POINTERS support on save state
vmstate: Add support for VBUFFERS
vmstate: Introduce VMSTATE_STRUCT_TEST
vmstate: Introduce VMSTATE_STRUCT_POINTER_TEST
vmstate: Introduce UINT16_TEST support
vmstate: remove usused VMSTATE_STRUCT_ARRAY_SIZE_UINT8
vmstate: Add support for multiplying size for a constant
pci: vmstate_register() already assign consecutive numbers starting
at 0
qdev: enable vmstate_unregister() support
savevm: Port to qdev.vmsd all devices that have qdev

 hw/ac97.c         |    2 +-
 hw/cirrus_vga.c   |    2 +-
 hw/cs4231a.c      |    2 +-
 hw/e1000.c        |    4 +--
 hw/es1370.c       |    2 +-
 hw/gus.c          |    2 +-
 hw/hw.h           |   82 +++++++++++++++++++++++++++++++++++++---------------
 hw/lance.c        |   14 ++++++++-
 hw/lm832x.c       |    2 +-
 hw/lsi53c895a.c   |    2 +-
 hw/max7310.c      |    2 +-
 hw/ne2000-isa.c   |   12 +++++++-
 hw/ne2000.c       |    3 +-
 hw/pci.c          |    4 +--
 hw/pckbd.c        |   13 ++++++++-
 hw/pcnet.c        |    4 +--
 hw/piix_pci.c     |    4 +-
 hw/qdev.c         |    2 -
 hw/rtl8139.c      |    4 +--
 hw/sb16.c         |    2 +-
 hw/ssd0303.c      |    2 +-
 hw/tmp105.c       |    2 +-
 hw/twl92230.c     |    2 +-
 hw/usb-uhci.c     |    3 +-
 hw/vga-pci.c      |    2 +-
 hw/vmware_vga.c   |    2 +-
 hw/wdt_i6300esb.c |    3 +-
 hw/wdt_ib700.c    |    2 +-
 hw/wm8750.c       |    2 +-
 savevm.c          |   49 ++++++++++++++++++++++++++------
 30 files changed, 159 insertions(+), 74 deletions(-)