Skip to content

Fixes related to mirror repair in clustered environment

Milan Broz lvm-devel 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest10 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/10Remove newly created log volume if initial deactivation fails.lib/metadata/mirror.c+11 -30 replies
2/10Get rid of hardcoded 0xffdf cluster lock flag.lib/locking/cluster_locking.c+1 -10 replies
3/10Get rid of magic masks in cluster locking code.lib/locking/cluster_locking.c lib/locking/locking.h+6 -21 reply
4/10Get rid of magic masks in cluster locking code - clvmd part.daemons/clvmd/clvmd-command.c+5 -50 replies
5/10Allow implicit "convert" to the same lock mode.daemons/clvmd/lvm-functions.c+5 -00 replies
6/10Allow manipulation with precommited metadata even when a PV is missing.lib/metadata/metadata.c+2 -20 replies
7/10Call explicitly suspend for temporary mirror layer.lib/metadata/mirror.c+11 -170 replies
8/10Allow implicit lock conversion for pre/post callbacks.daemons/clvmd/lvm-functions.c+3 -30 replies
9/10Never ever use distributed lock for LV in non-clustered VG.daemons/clvmd/lvm-functions.c+11 -100 replies
10/10Add memlock information to do_lock_lv debug output.daemons/clvmd/lvm-functions.c+3 -30 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 00/10] Fixes related to mirror repair in clustered environment

These are patches I created when trying to reproduce fails with recent mirror repair changes.

Because it touch the core cluster locking parts, I separated it to several simple patches to review it separately.

Please review and comment it - it is curretnly test blocker for clustering.

(If there is better way how to fix described problems - please let me know, I am quite desperate after debugging this code ;-)

Milan

Milan Broz (10):
Remove newly created log volume if initial deactivation fails. Get rid of hardcoded 0xffdf cluster lock flag.
Get rid of magic masks in cluster locking code.
Get rid of magic masks in cluster locking code - clvmd part. Allow implicit "convert" to the same lock mode. Allow manipulation with precommited metadata even when a PV is
missing.
Call explicitly suspend for temporary mirror layer. Allow implicit lock conversion for pre/post callbacks. Never ever use distributed lock for LV in non-clustered VG. Add memlock information to do_lock_lv debug output.

 daemons/clvmd/clvmd-command.c |   10 ++++----
 daemons/clvmd/lvm-functions.c |   38 +++++++++++++++++++++---------------
 lib/locking/cluster_locking.c |    7 +++--
 lib/locking/locking.h         |    3 ++
 lib/metadata/metadata.c       |    4 +-
 lib/metadata/mirror.c         |   42 +++++++++++++++++++++-------------------
 6 files changed, 58 insertions(+), 46 deletions(-)