Skip to content

tcg conditional set/move, round 2

Richard Henderson qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest6 patches 19 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6tcg: Generic support for conditional set and conditional move.tcg/README tcg/tcg-op.h tcg/tcg-opc.h +1 more+138 -72 replies
2/6tcg: Add tcg_invert_cond.tcg/tcg.h+5 -01 reply
3/6tcg-x86_64: Implement setcond and movcond.tcg/x86_64/tcg-target.c+62 -33 replies
4/6tcg-i386: Implement small forward branches.elf.h tcg/i386/tcg-target.c+27 -112 replies
5/6tcg-i386: Simplify brcond2.tcg/i386/tcg-target.c+40 -472 replies
6/6tcg-i386: Implement setcond, movcond, setcond2.tcg/i386/tcg-target.c+173 -00 replies

Reviews trailers per patch

1 of 6 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchLaurent Desnogues
SeriesA-b
1/6
2/6A-b
3/6
4/6
5/6
6/6

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [Qemu-devel] [PATCH 0/6] tcg conditional set/move, round 2
Quoted 1 line

funny how you seem to follow the same paths I did months ago :-)

Heh. They are the obvious points for improvement in the emulation. Hopefully we can get them finished this time, so that some third person doesn't go through the same thing next year. =)

Quoted 2 lines

- cosmetics: don't use tabs and be sure not to have whitespaces at end of lines

Grr, I thought I'd been extra careful about that. Fixed.

Quoted 1 line

- the changes to tcg-op.h in patch 6 should go with patch 1

Done.

Quoted 4 lines

- outside of the small parameter handling, I'd prefer you provide a separate patch for tcg_out_brcond2; I don't think the changes using c1, c2 and c3 really belong to setcond/movcond.

The i386 part has been split into 3 patches, though they are sequentially dependent.

I've left off the sparc backend patch, as well as the patches for the translators. Let's take care of these first.

r~
---

Richard Henderson (6):
tcg: Generic support for conditional set and conditional move.
tcg: Add tcg_invert_cond.
tcg-x86_64: Implement setcond and movcond.
tcg-i386: Implement small forward branches.
tcg-i386: Simplify brcond2.
tcg-i386: Implement setcond, movcond, setcond2.

 elf.h                   |    2 +
 tcg/README              |   26 ++++-
 tcg/i386/tcg-target.c   |  278 ++++++++++++++++++++++++++++++++++++++--------
 tcg/tcg-op.h            |   91 +++++++++++++++
 tcg/tcg-opc.h           |    5 +
 tcg/tcg.c               |   23 +++-
 tcg/tcg.h               |    5 +
 tcg/x86_64/tcg-target.c |   65 +++++++++++-
 8 files changed, 436 insertions(+), 59 deletions(-)