Skip to content

mips setcond and movcond

Richard Henderson qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3tcg: Add tcg_swap_cond.tcg/tcg.h+8 -00 replies
2/3tcg-mips: Implement setcond, setcond2.tcg/mips/tcg-target.c+177 -01 reply
3/3tcg-mips: Implement movcond.tcg/mips/tcg-target.c+117 -20 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [Qemu-devel] [PATCH 0/3] mips setcond and movcond

It has been compile tested, but nothing else.

I'm moderately surprised at the implementation of brcond. It's missing the BLTZ, BLEZ, BGTZ, BGEZ branches. It's could be improved with the SLTI and SLTIU insns used here with setcond.

Indeed, I suspect that a good implementation of brcond would be to take care of the cases implementable directly by branches, and then call into setcond to take care of the rest. I don't plan to do that.

r~

Richard Henderson (3):
tcg: Add tcg_swap_cond.
tcg-mips: Implement setcond, setcond2.
tcg-mips: Implement movcond.

 tcg/mips/tcg-target.c |  296 ++++++++++++++++++++++++++++++++++++++++++++++++-
 tcg/tcg.h             |    8 ++
 2 files changed, 302 insertions(+), 2 deletions(-)