Skip to content

drivers/block/floppy.c cleanups

Joe Perches lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest24 patches 3 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/24drivers/block/floppy.c: Convert some #include <asm/ to #include <linux/drivers/block/floppy.c+2 -20 replies
2/24drivers/block/floppy.c: #define space and column neateningdrivers/block/floppy.c+97 -830 replies
3/24drivers/block/floppy.c: Use pr_<level>drivers/block/floppy.c+175 -1780 replies
4/24drivers/block/floppy.c: Remove unnecessary bracesdrivers/block/floppy.c+17 -270 replies
5/24drivers/block/floppy.c: Remove used once CHECK_READY macrodrivers/block/floppy.c+4 -20 replies
6/24drivers/block/floppy.c: Hoist assigns from if()s, neateningdrivers/block/floppy.c+29 -240 replies
7/24drivers/block/floppy.c: Remove LAST_OUT macrodrivers/block/floppy.c+8 -40 replies
8/24drivers/block/floppy.c: Comment neatening and remove naked ;drivers/block/floppy.c+30 -250 replies
9/24drivers/block/floppy.c: Remove CLEARSTRUCT macro, use memsetdrivers/block/floppy.c+5 -70 replies
10/24drivers/block/floppy.c: Indent a commentdrivers/block/floppy.c+1 -10 replies
11/24drivers/block/floppy.c: Remove IN/OUT macros, indent switch/casedrivers/block/floppy.c+107 -1110 replies
12/24drivers/block/floppy.c: Remove a few spaces from function castsdrivers/block/floppy.c+4 -40 replies
13/24drivers/block/floppy.c: Remove macro LOCK_FDCdrivers/block/floppy.c+26 -170 replies
14/24drivers/block/floppy.c: Add debug_dcl(...) macrodrivers/block/floppy.c+31 -520 replies
15/24drivers/block/floppy.c: Remove [U]CLEARF, [U]SETF, and [U]TESTF macrosdrivers/block/floppy.c+47 -470 replies
16/24drivers/block/floppy.c: Remove most uses of CALL and ECALL macrosdrivers/block/floppy.c+35 -160 replies
17/24drivers/block/floppy.c: remove [_]COPYIN [_]COPYOUT and ECALL macrosdrivers/block/floppy.c+6 -110 replies
18/24drivers/block/floppy.c: remove macros CALL, WAIT and IWAITdrivers/block/floppy.c+8 -100 replies
19/24drivers/block/floppy.c: convert int 1/0 to bool true/falsedrivers/block/floppy.c+30 -300 replies
20/24drivers/block/floppy.c: Move leading && and || to preceding linedrivers/block/floppy.c+4 -40 replies
21/24drivers/block/floppy.c: remove #define DEVICE_NAME "floppy"drivers/block/floppy.c+1 -30 replies
22/24drivers/block/floppy.c: Convert int initialising to bool initializeddrivers/block/floppy.c+10 -110 replies
23/24drivers/block/floppy.c: Add function is_ready_statedrivers/block/floppy.c+15 -40 replies
24/24drivers/block/floppy.c: Remove unnecessary return and bracesdrivers/block/floppy.c+1 -30 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 00/24] drivers/block/floppy.c cleanups

Since Stephen Hemminger is a bit too busy to do much with this I've broken up the first large patch into multiple pieces and brought the rest up to current.

I dropped the c99 conversions because Bartlomiej Zolnierkiewicz objected.

This applies against Linus' and -next.

Maybe somebody will decide it's useful.

Original submissions:
http://lkml.org/lkml/2009/11/30/511
http://lkml.org/lkml/2009/12/2/14

Joe Perches (24):
drivers/block/floppy.c: Convert some #include <asm/ to #include <linux/ drivers/block/floppy.c: #define space and column neatening drivers/block/floppy.c: Use pr_<level> drivers/block/floppy.c: Remove unnecessary braces drivers/block/floppy.c: Remove used once CHECK_READY macro drivers/block/floppy.c: Hoist assigns from if()s, neatening drivers/block/floppy.c: Remove LAST_OUT macro drivers/block/floppy.c: Comment neatening and remove naked ; drivers/block/floppy.c: Remove CLEARSTRUCT macro, use memset drivers/block/floppy.c: Indent a comment drivers/block/floppy.c: Remove IN/OUT macros, indent switch/case drivers/block/floppy.c: Remove a few spaces from function casts drivers/block/floppy.c: Remove macro LOCK_FDC drivers/block/floppy.c: Add debug_dcl(...) macro drivers/block/floppy.c: Remove [U]CLEARF, [U]SETF, and [U]TESTF macros drivers/block/floppy.c: Remove most uses of CALL and ECALL macros drivers/block/floppy.c: remove [_]COPYIN [_]COPYOUT and ECALL macros drivers/block/floppy.c: remove macros CALL, WAIT and IWAIT drivers/block/floppy.c: convert int 1/0 to bool true/false drivers/block/floppy.c: Move leading && and || to preceding line drivers/block/floppy.c: remove #define DEVICE_NAME "floppy" drivers/block/floppy.c: Convert int initialising to bool initialized drivers/block/floppy.c: Add function is_ready_state drivers/block/floppy.c: Remove unnecessary return and braces

 drivers/block/floppy.c | 1219 ++++++++++++++++++++++++------------------------
 1 files changed, 618 insertions(+), 601 deletions(-)