CAPI: Major rework, tons of bug fixes
Status from this message: I've applied your entire series to net-next-2.6
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest41 patches 5 repliesApplied
- v131 patches 11 repliesSuperseded
Patches in v2 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/41 | CAPI: Fix leaks in capifs_new_nccidrivers/ | +18 | 0 replies | |
| 2/41 | CAPI: Sanitize capifs APIdrivers/ drivers/ drivers/ | +54 | 0 replies | |
| 3/41 | CAPI: Eliminate capifs_root variabledrivers/ | +10 | 0 replies | |
| 4/41 | CAPI: Pin capifs instead of mounting itdrivers/ | +18 | 0 replies | |
| 5/41 | CAPI: Reduce chattiness during module loading/removaldrivers/ drivers/ drivers/ +1 more | +9 | 0 replies | |
| 6/41 | CAPI: Call a controller 'controller', not 'card'drivers/ drivers/ drivers/ +1 more | +178 | 0 replies | |
| 7/41 | CAPI: Convert capi drivers rwlock into mutexdrivers/ drivers/ drivers/ | +27 | 0 replies | |
| 8/41 | CAPI: Rework capi_ctr_ready/downdrivers/ | +50 | 0 replies | |
| 9/41 | CAPI: Rework controller state notifierdrivers/ drivers/ include/ | +72 | 0 replies | |
| 10/41 | CAPI: Rework locking of controller data structuresdrivers/ drivers/ drivers/ +1 more | +217 | 0 replies | |
| 11/41 | CAPI: Rework application lockingdrivers/ drivers/ | +29 | 0 replies | |
| 12/41 | CAPI: Reduce #ifdef mess around CONFIG_ISDN_CAPI_MIDDLEWAREdrivers/ | +83 | 0 replies | |
| 13/41 | CAPI: Convert capidev_list_lock into a mutexdrivers/ | +12 | 0 replies | |
| 14/41 | CAPI: Clean up capi_open/releasedrivers/ | +34 | 0 replies | |
| 15/41 | CAPI: Rework locking of capidev membersdrivers/ | +88 | 0 replies | |
| 16/41 | CAPI: Use non-atomic allocation during NCCI setupdrivers/ | +2 | 0 replies | |
| 17/41 | CAPI: Fix racy capi_readdrivers/ | +7 | 0 replies | |
| 18/41 | CAPI: Switch NCCI list to standard doubly linked listdrivers/ | +20 | 0 replies | |
| 19/41 | CAPI: Switch capiminor list to arraydrivers/ | +35 | 0 replies | |
| 20/41 | CAPI: Clean up capinc_tty_init/exitdrivers/ | +10 | 0 replies | |
| 21/41 | CAPI: Dynamically register minor devicesdrivers/ | +24 | 0 replies | |
| 22/41 | CAPI: Use dynamic major for NCCI TTYs by defaultdrivers/ | +4 | 0 replies | |
| 23/41 | CAPI: Use kref on capiminordrivers/ | +28 | 0 replies | |
| 24/41 | CAPI: Establish install/cleanup handlers for capiminor TTYsdrivers/ | +28 | 0 replies | |
| 25/41 | CAPI: Use tty_port to keep track of capiminor's ttydrivers/ | +62 | 0 replies | |
| 26/41 | CAPI: Drop remaining NULL checks on tty->driver_datadrivers/ | +31 | 0 replies | |
| 27/41 | CAPI: Issue synchronous hangup on capincci_free_minordrivers/ | +1 | 0 replies | |
| 28/41 | CAPI: Drop obsolete nccip from capiminor structdrivers/ | +1 | 0 replies | |
| 29/41 | CAPI: Clean up capiminors_lockdrivers/ | +9 | 0 replies | |
| 30/41 | CAPI: Drop atomic ttyopencountdrivers/ | +10 | 0 replies | |
| 31/41 | CAPI: Drop handle_minor_recv from capinc_tty_writedrivers/ | +0 | 0 replies | |
| 32/41 | CAPI: Rework capiminor RX handlerdrivers/ | +38 | 0 replies | |
| 33/41 | CAPI: Rename datahandle_queue -> ackqueue_entrydrivers/ | +4 | 0 replies | |
| 34/41 | CAPI: Use atomics for capiminor's datahandle and msgiddrivers/ | +7 | 0 replies | |
| 35/41 | CAPI: Drop capiminor's unused inbytes counterdrivers/ | +3 | 0 replies | |
| 36/41 | CAPI: Fix locking around capiminor's output queue and drop workaround_lockdrivers/ | +67 | 0 replies | |
| 37/41 | CAPI: Clean up capiminor_*_ackdrivers/ | +7 | 0 replies | |
| 38/41 | CAPI: Drop return value of handle_minor_senddrivers/ | +9 | 0 replies | |
| 39/41 | CAPI: Drop special controller lookup from capi20_put_messagedrivers/ | +2 | 0 replies | |
| 40/41 | CAPI: Schedule capifs for removalDocumentation/ drivers/ | +17 | 0 replies | |
| 41/41 | CAPI: Remove experimental tag from middleware featuredrivers/ | +1 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.
Cover letter [PATCH v2 00/41] CAPI: Major rework, tons of bug fixes
Here is the second take of my CAPI rework. I tried to address all feedback on v1, so this one comes with the following changes:
o rebased over net-next
o reworked locking of the NCCI TTY using latest and greatest tty_port features and kref, hopefully in the right way
o more fine-grained patch steps for the tricky TTY rework
o dynamic major for NCCI TTYs, ie. CAPI no longer claims 191
o dynamic TTY minor registrations, completely obsoleting capifs
o schedule capifs for removal
o some small additional cleanups
I kept my capifs fixes though this thing should die in the future. The work is done, and people may still use it due to their distro configuration (and the hard-wired loading by capiinit - needs fixing).
You can pull this series from
git://git.kiszka.org/linux-2.6.git capi
Jan
Jan Kiszka (41):
CAPI: Fix leaks in capifs_new_ncci
CAPI: Sanitize capifs API
CAPI: Eliminate capifs_root variable
CAPI: Pin capifs instead of mounting it
CAPI: Reduce chattiness during module loading/removal
CAPI: Call a controller 'controller', not 'card'
CAPI: Convert capi drivers rwlock into mutex
CAPI: Rework capi_ctr_ready/down
CAPI: Rework controller state notifier
CAPI: Rework locking of controller data structures
CAPI: Rework application locking
CAPI: Reduce #ifdef mess around CONFIG_ISDN_CAPI_MIDDLEWARE
CAPI: Convert capidev_list_lock into a mutex
CAPI: Clean up capi_open/release
CAPI: Rework locking of capidev members
CAPI: Use non-atomic allocation during NCCI setup
CAPI: Fix racy capi_read
CAPI: Switch NCCI list to standard doubly linked list
CAPI: Switch capiminor list to array
CAPI: Clean up capinc_tty_init/exit
CAPI: Dynamically register minor devices
CAPI: Use dynamic major for NCCI TTYs by default
CAPI: Use kref on capiminor
CAPI: Establish install/cleanup handlers for capiminor TTYs
CAPI: Use tty_port to keep track of capiminor's tty
CAPI: Drop remaining NULL checks on tty->driver_data
CAPI: Issue synchronous hangup on capincci_free_minor
CAPI: Drop obsolete nccip from capiminor struct
CAPI: Clean up capiminors_lock
CAPI: Drop atomic ttyopencount
CAPI: Drop handle_minor_recv from capinc_tty_write
CAPI: Rework capiminor RX handler
CAPI: Rename datahandle_queue -> ackqueue_entry
CAPI: Use atomics for capiminor's datahandle and msgid
CAPI: Drop capiminor's unused inbytes counter
CAPI: Fix locking around capiminor's output queue and drop
workaround_lock
CAPI: Clean up capiminor_*_ack
CAPI: Drop return value of handle_minor_send
CAPI: Drop special controller lookup from capi20_put_message
CAPI: Schedule capifs for removal
CAPI: Remove experimental tag from middleware feature
Documentation/feature-removal-schedule.txt | 10 + drivers/isdn/capi/Kconfig | 16 +- drivers/isdn/capi/capi.c | 1108 ++++++++++++++-------------- drivers/isdn/capi/capidrv.c | 48 +- drivers/isdn/capi/capifs.c | 126 ++-- drivers/isdn/capi/capifs.h | 21 +- drivers/isdn/capi/kcapi.c | 805 +++++++++++--------- drivers/isdn/capi/kcapi.h | 13 +- drivers/isdn/capi/kcapi_proc.c | 41 +- include/linux/isdn/capilli.h | 5 +- include/linux/kernelcapi.h | 17 +- 11 files changed, 1151 insertions(+), 1059 deletions(-)