RFC Add netdev_printk and netif_printk macros
Get series with b4
b4 am [email protected]Versions newest first
- v1 RFC Latest7 patches 4 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/7 | netdevice.h: Add netdev_printk helpers like dev_printkinclude/ | +71 | 0 replies | |
| 2/7 | drivers/net/atl1e: Use netdev_printk helpersdrivers/ drivers/ drivers/ | +99 | 0 replies | |
| 3/7 | include/linux/netdevice.h: Add netif_printk helpersinclude/ | +53 | 0 replies | |
| 4/7 | drivers/net/r8196.c: Use netif_printk macrosdrivers/ | +48 | 0 replies | |
| 5/7 | drivers/net/jme: Use netif_printk helpersdrivers/ drivers/ | +34 | 0 replies | |
| 6/7 | drivers/net/qlge: Use netif_printk helpersdrivers/ drivers/ drivers/ +2 more | +580 | 0 replies | |
| 7/7 | drivers/net/skge.c: Use netif_printk macrosdrivers/ | +29 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [RFC PATCH net-next 0/7] Add netdev_printk and netif_printk macros
Some logging messages duplicate the driver name with the device name like:
ATL1E 0000:03:00.0: ATL1E: eth0 NIC Link is Up<100 Mbps Full Duplex>
Some drivers/net/... have created netif_ macros like:
drivers/net/sis190.c:#define net_drv(p, arg...) if (netif_msg_drv(p)) \drivers/net/sis190.c- printk(arg)
drivers/net/sis190.c:#define net_probe(p, arg...) if (netif_msg_probe(p)) \drivers/net/sis190.c- printk(arg)
drivers/net/sis190.c:#define net_link(p, arg...) if (netif_msg_link(p)) \drivers/net/sis190.c- printk(arg)
drivers/net/sis190.c:#define net_intr(p, arg...) if (netif_msg_intr(p)) \drivers/net/sis190.c- printk(arg)
drivers/net/sis190.c:#define net_tx_err(p, arg...) if (netif_msg_tx_err(p)) \drivers/net/sis190.c- printk(arg)
This RFC patch creates a set of these macros to standardize the coding and logging style of struct net_device and netif_msg macros
I think they're useful, might be mindless churn to others.
The atl1e change reduces log duplicate names.
The qlge change is an example of what be mindless churn for standardization sake, the r8169, jme, and skge are more reasonable.
Comments?
Joe Perches (7):
netdevice.h: Add netdev_printk helpers like dev_printk drivers/net/atl1e: Use netdev_printk helpers include/linux/netdevice.h: Add netif_printk helpers drivers/net/r8196.c: Use netif_printk macros drivers/net/jme: Use netif_printk helpers drivers/net/qlge: Use netif_printk helpers drivers/net/skge.c: Use netif_printk macros
drivers/net/atl1e/atl1e_hw.c | 23 +- drivers/net/atl1e/atl1e_main.c | 153 ++++---- drivers/net/atl1e/atl1e_param.c | 35 +- drivers/net/jme.c | 54 ++-- drivers/net/jme.h | 41 +-- drivers/net/qlge/qlge.h | 8 - drivers/net/qlge/qlge_dbg.c | 58 ++-- drivers/net/qlge/qlge_ethtool.c | 49 ++- drivers/net/qlge/qlge_main.c | 841 ++++++++++++++++++++------------------- drivers/net/qlge/qlge_mpi.c | 183 ++++----- drivers/net/r8169.c | 136 +++---- drivers/net/skge.c | 73 ++-- include/linux/netdevice.h | 124 ++++++ 13 files changed, 914 insertions(+), 864 deletions(-)