Skip to content

*** fix gcc warnings ***

Luca Berra linux-raid 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 4 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3fix gcc warnings about strict-aliasing rulesutil.c+2 -23 replies
2/3fix compiler warningsGrow.c mdmon.c restripe.c+6 -50 replies
3/3workaround unused resultsGrow.c+15 -80 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [mdadm PATCH 0/3] *** fix gcc warnings ***

building current git with -O2 -Wall -Werror aborts with compiler warnings patch 1 fixes a strict-aliasing violation
patch 2 addresses trivial to fix warning
patch 3 is just _WRONG_: there is no clear way to bailout from the functions in Grow.c, and i have no idea if aborting would leave the array in an inconsistent state. For the time being I just decided to please gcc by storing the result somwere, but it is never checked.

L.

Luca Berra (3):
fix gcc warnings about strict-aliasing rules
fix compiler warnings
workaround unused_results

 Grow.c     |   30 +++++++++++++++++++-----------
 mdmon.c    |    2 +-
 restripe.c |    2 +-
 util.c     |    4 ++--
 4 files changed, 23 insertions(+), 15 deletions(-)
Signature · 6 lines
Luca Berra -- [email protected]
        Communication Media & Services S.r.l.
 /"\
 \ /     ASCII RIBBON CAMPAIGN
  X        AGAINST HTML MAIL
 / \