FORTIFY_SOURCE followup
Status from this message: Applied all. Thanks.
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest10 patches 2 repliesApplied
- v110 patches 5 repliesSuperseded
Changes in v2 from the cover letter
- drop un-needed slirp exit() patch (kevin)
- add qemu_write_full() documentation (danp)
- use strerror(-errno) (kevin, pbonzini)
Patches in v2 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/10 | cow: return errno instead of -1block/ | +2 | 1 reply | |
| 2/10 | slirp: check system() successnet/ | +1 | 1 reply | |
| 3/10 | qcow2: return errno instead of -1block/ | +9 | 0 replies | |
| 4/10 | qcow: return errno instead of -1block/ | +4 | 0 replies | |
| 5/10 | vmdk: return errno instead of -1block/ | +7 | 0 replies | |
| 6/10 | vmdk: make vmdk_snapshot_create return -errnoblock/ | +58 | 0 replies | |
| 7/10 | vmdk: fix double freeblock/ | +1 | 0 replies | |
| 8/10 | vmdk: share cleanup codeblock/ | +4 | 0 replies | |
| 9/10 | block: print errno on errorqemu-img.c | +2 | 0 replies | |
| 10/10 | documentation: qemu_write_full don't work with non-blocking fd'sosdep.c | +5 | 0 replies |
Reviews trailers per patch
1 of 10 patches has a Reviewed-by or Acked-by.
| Patch | Michael S. Tsirkin |
|---|---|
| 1/10 | |
| 2/10 | A-b |
| 3/10 | |
| 4/10 | |
| 5/10 | |
| 6/10 | |
| 7/10 | |
| 8/10 | |
| 9/10 | |
| 10/10 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [Qemu-devel] [PATCH v2 00/10] FORTIFY_SOURCE followup
Hi
Series updated with yesterday comments
v2:
- drop un-needed slirp exit() patch (kevin)
- add qemu_write_full() documentation (danp)
- use strerror(-errno) (kevin, pbonzini)
Please review and apply.
Later, Juan.
v1:
This series make:
- all block *_create() functions return -errno instead of -1
- this makes that we can end writting errno/error at bdrv_create() callers (qemu-img)
- once there found a double free problem in the error handling of vmdk, fixed it.
- slirp: also check that system() was able to fork (amit noticed it)
- daemonize: if we are unable to write into the pipe, print a message and exit. We can't really recover from that error (amit noticed it).
Juan Quintela (10):
cow: return errno instead of -1
slirp: check system() success
qcow2: return errno instead of -1
qcow: return errno instead of -1
vmdk: return errno instead of -1
vmdk: make vmdk_snapshot_create return -errno
vmdk: fix double free
vmdk: share cleanup code
block: print errno on error
documentation: qemu_write_full don't work with non-blocking fd's
block/cow.c | 5 +-- block/qcow.c | 8 ++-- block/qcow2.c | 18 +++++----- block/vmdk.c | 106 +++++++++++++++++++++++++++++++++++++-------------------- net/slirp.c | 2 +- osdep.c | 5 +++ qemu-img.c | 4 +- 7 files changed, 92 insertions(+), 56 deletions(-)