Skip to content

FORTIFY_SOURCE followup

Juan Quintela qemu-devel 2 versions – Applied

Status from this message: Applied all. Thanks.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest10 patches 2 repliesApplied
  2. v110 patches 5 repliesSuperseded

Changes in v2 from the cover letter

- drop un-needed slirp exit() patch (kevin)
- add qemu_write_full() documentation (danp)
- use strerror(-errno) (kevin, pbonzini)

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/10cow: return errno instead of -1block/cow.c+2 -31 reply
2/10slirp: check system() successnet/slirp.c+1 -11 reply
3/10qcow2: return errno instead of -1block/qcow2.c+9 -90 replies
4/10qcow: return errno instead of -1block/qcow.c+4 -40 replies
5/10vmdk: return errno instead of -1block/vmdk.c+7 -70 replies
6/10vmdk: make vmdk_snapshot_create return -errnoblock/vmdk.c+58 -210 replies
7/10vmdk: fix double freeblock/vmdk.c+1 -10 replies
8/10vmdk: share cleanup codeblock/vmdk.c+4 -90 replies
9/10block: print errno on errorqemu-img.c+2 -20 replies
10/10documentation: qemu_write_full don't work with non-blocking fd'sosdep.c+5 -00 replies

Reviews trailers per patch

1 of 10 patches has a Reviewed-by or Acked-by.

PatchMichael S. Tsirkin
1/10
2/10A-b
3/10
4/10
5/10
6/10
7/10
8/10
9/10
10/10

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [Qemu-devel] [PATCH v2 00/10] FORTIFY_SOURCE followup

Hi

Series updated with yesterday comments

v2:
- drop un-needed slirp exit() patch (kevin)
- add qemu_write_full() documentation (danp)
- use strerror(-errno) (kevin, pbonzini)

Please review and apply.

Later, Juan.

v1:
This series make:
- all block *_create() functions return -errno instead of -1
- this makes that we can end writting errno/error at bdrv_create() callers (qemu-img)
- once there found a double free problem in the error handling of vmdk, fixed it.
- slirp: also check that system() was able to fork (amit noticed it)
- daemonize: if we are unable to write into the pipe, print a message and exit. We can't really recover from that error (amit noticed it).

Juan Quintela (10):
cow: return errno instead of -1
slirp: check system() success
qcow2: return errno instead of -1
qcow: return errno instead of -1
vmdk: return errno instead of -1
vmdk: make vmdk_snapshot_create return -errno
vmdk: fix double free
vmdk: share cleanup code
block: print errno on error
documentation: qemu_write_full don't work with non-blocking fd's

 block/cow.c   |    5 +--
 block/qcow.c  |    8 ++--
 block/qcow2.c |   18 +++++-----
 block/vmdk.c  |  106 +++++++++++++++++++++++++++++++++++++--------------------
 net/slirp.c   |    2 +-
 osdep.c       |    5 +++
 qemu-img.c    |    4 +-
 7 files changed, 92 insertions(+), 56 deletions(-)