Skip to content

target-alpha improvements

Richard Henderson qemu-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest10 patches 13 repliesIn review
  2. v18 patches 0 repliesSuperseded

Changes in v3 from the cover letter

* Enable NPTL.

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/10target-alpha: Add flags markups to helpers.h.target-alpha/helper.h+92 -920 replies
2/10target-alpha: Implement cpys{, n, e} inline.target-alpha/helper.h target-alpha/op_helper.c target-alpha/translate.c+74 -260 replies
3/10target-alpha: Implement rs/rc properly.linux-user/main.c target-alpha/helper.h target-alpha/op_helper.c +1 more+22 -320 replies
4/10target-alpha: Implement cvtql inline.target-alpha/helper.h target-alpha/op_helper.c target-alpha/translate.c+39 -300 replies
5/10target-alpha: Implement cvtlq inline.target-alpha/helper.h target-alpha/op_helper.c target-alpha/translate.c+20 -90 replies
6/10target-alpha: Use setcond for int comparisons.target-alpha/translate.c+22 -210 replies
7/10target-alpha: Use non-inverted arguments to gen_{f}cmov.target-alpha/translate.c+19 -180 replies
8/10target-alpha: Emit goto_tb opcodes.target-alpha/translate.c+193 -1460 replies
9/10target-alpha: Implement load-locked/store-conditional properly.linux-user/main.c target-alpha/cpu.h target-alpha/helper.c +3 more+168 -7110 replies
10/10target-alpha: Enable NPTL.configure linux-user/syscall.c target-alpha/cpu.h+19 -120 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [Qemu-devel] [PATCH 00/10, v3] target-alpha improvements

Changes from v1->v2:
* Use setcond and goto_tb.

Changes from v2->v3:
* Enable NPTL.

I don't see how any sort of emulation of cmpxchg/load-locked is working for any currently enabled nptl target. I think how I've approached handling load-locked for alpha is probably the easiest way. Slightly better would be if TCG had a (set of) cmpxchg opcodes, which would have the benefit of getting the virt->phys->host address (and segfault handling) more correct. I've sort of totally ignored the faulting for now.

This is just good enough to not immediately fail the glibc testsuite for alpha, as the default glibc test skeleton uses clone. I'm concurrently debuging the glibc-alpha port and the qemu-alpha syscall emulation, so it's not always clear which is at fault.

r~

Richard Henderson (10):
target-alpha: Add flags markups to helpers.h.
target-alpha: Implement cpys{,n,e} inline.
target-alpha: Implement rs/rc properly.
target-alpha: Implement cvtql inline.
target-alpha: Implement cvtlq inline.
target-alpha: Use setcond for int comparisons.
target-alpha: Use non-inverted arguments to gen_{f}cmov.
target-alpha: Emit goto_tb opcodes.
target-alpha: Implement load-locked/store-conditional properly.
target-alpha: Enable NPTL.

 configure                |    1 +
 linux-user/main.c        |   16 +
 linux-user/syscall.c     |    2 +-
 target-alpha/cpu.h       |   31 ++-
 target-alpha/helper.c    |    6 +-
 target-alpha/helper.h    |  182 ++++++------
 target-alpha/op_helper.c |  131 +++++----
 target-alpha/translate.c |  722 +++++++++++++++++++++++++++++-----------------
 8 files changed, 651 insertions(+), 440 deletions(-)