Skip to content

dmevent mlockall() fixes

Zdenek Kabelac lvm-devel 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest7 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7Remove mlockall() form dmeventddaemons/dmeventd/dmeventd.c+0 -80 replies
2/7Fix resouces leak in error pathdaemons/dmeventd/dmeventd.c+2 -10 replies
3/7Release pool in the same reversed orderdaemons/dmeventd/plugins/lvm2/dmeventd_lvm.c+2 -20 replies
4/7Updated syslog messagesdaemons/dmeventd/plugins/mirror/dmeventd_mirror.c+14 -140 replies
5/7Force C localedaemons/dmeventd/dmeventd.c+3 -00 replies
6/7Update memlocklib/mm/memlock.c+22 -130 replies
7/7Count only readable size for memlock stats.lib/mm/memlock.c+12 -250 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/7] dmevent mlockall() fixes

This patch set tries to fix dmeventd.

Dmeventd got actually broken with our new mlock() code. There is no big chance to make current architecture with threads usable with mlock() code - so mlockall() is used for daemon case.

Snapshot plugin current doesn't use cmd_context and doesn't need memory locking.

Mirror plugin uses memlock_inc_daemon() and locks while binary to memory.

C locales are enforced to avoid loading of 100MB locale-archive file.

Few minor fixes for syslog message and resource leaks in error path.

Statistic for mlock() could be based on readable sizes.

Zdenek Kabelac (7):
Remove mlockall() form dmeventd
Fix resouces leak in error path
Release pool in the same reversed order
Updated syslog messages
Force C locale
Update memlock
Count only readable size for memlock stats.

 daemons/dmeventd/dmeventd.c                       |   14 ++---
 daemons/dmeventd/plugins/lvm2/dmeventd_lvm.c      |    4 +-
 daemons/dmeventd/plugins/mirror/dmeventd_mirror.c |   28 +++++-----
 lib/mm/memlock.c                                  |   64 ++++++++++-----------
 4 files changed, 51 insertions(+), 59 deletions(-)