virtio: virtqueue ops cleanup
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest6 patches 2 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/6 | virtio: add virtqueue_ vq_ops wrappersinclude/ | +34 | 0 replies | |
| 2/6 | virtio_balloon: use virtqueue_xxx wrappersdrivers/ | +8 | 0 replies | |
| 3/6 | virtio_console: use virtqueue_xxx wrappersdrivers/ | +16 | 0 replies | |
| 4/6 | virtio_blk: use virtqueue_xxx wrappersdrivers/ | +3 | 0 replies | |
| 5/6 | virtio_net: use virtqueue_xxx wrappersdrivers/ | +23 | 0 replies | |
| 6/6 | virtio_ring: remove a level of indirectiondrivers/ include/ | +34 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 0/6] virtio: virtqueue ops cleanup
virtqueue ops were introduced in the hope that we'll have multiple implementations besides virtio_ring, but none have surfaced so far, and given that existing virtio ring is deployed in production we are likely stuck with it now, so this layer just adds complexity and overhead.
Further, the need to pass vq twice to each call (as in dev->vq->vq_ops->kick(dev->vq) ) adds potential for cut and paste errors.
This patchset does the following:
- add inline wrappers converting the above to virtqueue_kick(dev->vq)
- convert all users to this API
- remove vq_ops indirection, implementing virtqueue_xx directly in virtio_ring
Note that if we ever want to add another vring implementation, we'll only need to revert the last patch in the series, devices won't have to change.
Signature · 18 lines
MST Michael S. Tsirkin (6): virtio: add virtqueue_ vq_ops wrappers virtio_balloon: use virtqueue_xxx wrappers virtio_console: use virtqueue_xxx wrappers virtio_blk: use virtqueue_xxx wrappers virtio_net: use virtqueue_xxx wrappers virtio_ring: remove a level of indirection drivers/block/virtio_blk.c | 6 ++-- drivers/char/virtio_console.c | 32 +++++++++++++------------- drivers/net/virtio_net.c | 46 +++++++++++++++++++------------------- drivers/virtio/virtio_balloon.c | 17 ++++++------- drivers/virtio/virtio_ring.c | 36 +++++++++++++----------------- include/linux/virtio.h | 43 +++++++++++++++++------------------ 6 files changed, 87 insertions(+), 93 deletions(-)